-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Schema validations ignore not null on Teradata and BigQuery #935
Conversation
…orting table for Hive
Please do not review this yet. I am getting a Python |
You may want to try re-running the build to make sure it's not an ephemeral error |
…alidations-ignore-notnull
This reverts commit f66dc86.
/gcbrun |
@nehanene15 , you were right, the build failure was transient. Once the test had run they highlighted other issues for me to work on. This should now be ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This change adds code to correctly identify nullable True/False on Teradata and BigQuery, bringing them into line with other engines (MySQL, Oracle, PostgreSQL, Snowflake, SQL Server).
It also adds tests for all of these engines to avoid regressions.
It does not add support or tests for these engines:
SELECT * ... LIMIT 0
query which does not expose schema attributes. I feel this is too far removed from DVT to tackleWe did talk about adding a flag to give users the option to ignore nullable True/False for schema validations, this would be useful for Hive and Spanner. But I decided that it would be a feature request and not a function of this issue.