Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add missing SnowflakeDialect mapping for BINARY data type #959

Merged
merged 2 commits into from
Aug 29, 2023
Merged

fix: Add missing SnowflakeDialect mapping for BINARY data type #959

merged 2 commits into from
Aug 29, 2023

Conversation

helensilva14
Copy link
Contributor

Closes #958

/gcbrun

@helensilva14 helensilva14 requested a review from a team as a code owner August 28, 2023 17:54
@helensilva14 helensilva14 linked an issue Aug 28, 2023 that may be closed by this pull request
Snowflake and BINARY datatype #958
Closed
nehanene15
nehanene15 approved these changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@nehanene15 nehanene15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@helensilva14 helensilva14 merged commit 9ad529a into develop Aug 29, 2023
3 checks passed
@helensilva14 helensilva14 deleted the issue958-snowflake-missing-binary-datatype branch August 29, 2023 16:53
@release-please release-please bot mentioned this pull request Aug 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nehanene15 nehanene15 nehanene15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Snowflake and BINARY datatype
2 participants
@helensilva14 @nehanene15