feat: Support standard deviation for column agg #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
helensilva14
added
the
priority: p0
Raniksingh
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Issue #963 by adding support for standard deviation for column aggregations.
For now, we only support the default sample standard deviation here: https://ibis-project.org/reference/expressions/numeric/#ibis.expr.types.numeric.NumericColumn.std
Also removed the
test_schema_validationsystem test for BQ since it tests the same functionality astest_schema_validation_core_types.This PR also includes a fix for TD CAST - previously we casted to the invalid 'NUMERIC' type, changed it to 'DECIMAL' in this PR. (Reference)