Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: yaml validation files in gcs #977

Merged
merged 2 commits into from
Sep 28, 2023
Merged

fix: yaml validation files in gcs #977

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b89bec9
Fix to accept GCS paths in configs run -c
sundar-mudupalli-work Sep 7, 2023
4d1bc49
Blacken files
sundar-mudupalli-work Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions data_validation/cli_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1062,8 +1062,16 @@ def get_validation(validation_name, config_dir=None):
mgr = state_manager.StateManager(file_system_root_path=config_dir)
return mgr.get_validation_config(validation_name, config_dir)
else:
mgr = state_manager.StateManager()
return mgr.get_validation_config(validation_name)
if validation_name.startswith("gs://"):
nehanene15 marked this conversation as resolved.
Show resolved Hide resolved
obj_depth = len(validation_name.split("/"))
gcs_prefix = "/".join(validation_name.split("/")[: obj_depth - 1])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be easier than getting the depth - 1: "/".join(file.split("/")[:-1])

mgr = state_manager.StateManager(file_system_root_path=gcs_prefix)
return mgr.get_validation_config(
validation_name.split("/")[obj_depth - 1], gcs_prefix
)
else:
mgr = state_manager.StateManager()
return mgr.get_validation_config(validation_name)


def list_validations():
Expand Down