Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: emit metrics for exec, verify and render #9078

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

renzodavid9
Copy link
Contributor

Fixes: #9073

Description
Cherry pick of #9020 and #9013 for v2.6

* feat: configure render, verify, and exec commands to emit metrics

* fix: remove render command from tracking due to corrupted output data
* feat: making survey, update, and tracking messages to print to stderr instead of stdout

* feat: enable `skaffold render` to track telemetry

* feat: remove tests checking if a stadout is set, now we are using stderr

* feat: make stderr used to print survey, update, and metricts promp, coloreable to keep same behaviour as stdin

* feat: removing IsStdout function and related tests
@renzodavid9 renzodavid9 changed the title Commands tracking feat: emit metrics for exec, verify and render Sep 7, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release/v2.6@8f37e9d). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             release/v2.6    #9078   +/-   ##
===============================================
  Coverage                ?   63.61%           
===============================================
  Files                   ?      624           
  Lines                   ?    31916           
  Branches                ?        0           
===============================================
  Hits                    ?    20304           
  Misses                  ?    10084           
  Partials                ?     1528           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

📢 Have feedback on the report? Share it here.

@renzodavid9 renzodavid9 marked this pull request as ready for review September 8, 2023 15:39
@renzodavid9 renzodavid9 merged commit a753d4c into release/v2.6 Sep 8, 2023
21 checks passed
@renzodavid9 renzodavid9 deleted the commands-tracking branch September 8, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants