fix: Enable docker build without cli #9178
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9103
Description:
dev, run, debug
command, skaffold always uses cli to build for docker builder in build phaseif
condition that enable docker-cli by changing|| matcher.isEmpty
to|| matcher.isCrossPlatform
, So when user does not need to build cross-platform image, they don't have to have docker-cli installed, I think that what the comment was meant to as well.skaffold/deploy/skaffold/Dockerfile
Line 22 in 2fc43f6