Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert cache lookup changes #9313

Merged

Conversation

@ericzzzzzzz ericzzzzzzz marked this pull request as ready for review February 15, 2024 11:02
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 295 lines in your changes are missing coverage. Please review.

Comparison is base (290280e) 70.48% compared to head (ade1a17) 63.55%.
Report is 1114 commits behind head on main.

Files Patch % Lines
cmd/skaffold/app/cmd/exec.go 16.32% 40 Missing and 1 partial ⚠️
cmd/skaffold/app/cmd/filter.go 47.27% 22 Missing and 7 partials ⚠️
cmd/skaffold/app/cmd/lsp.go 28.12% 23 Missing ⚠️
cmd/skaffold/app/cmd/verify.go 23.33% 23 Missing ⚠️
cmd/skaffold/app/cmd/fix.go 51.16% 17 Missing and 4 partials ⚠️
cmd/skaffold/app/cmd/inspect_job_manifest_paths.go 60.00% 15 Missing and 1 partial ⚠️
cmd/skaffold/app/cmd/inspect_namespaces.go 50.00% 13 Missing and 1 partial ⚠️
...md/skaffold/app/cmd/inspect_config_dependencies.go 45.83% 12 Missing and 1 partial ⚠️
cmd/skaffold/app/cmd/lint.go 42.85% 12 Missing ⚠️
cmd/skaffold/app/cmd/inspect_build_env.go 60.71% 11 Missing ⚠️
... and 21 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9313      +/-   ##
==========================================
- Coverage   70.48%   63.55%   -6.93%     
==========================================
  Files         515      635     +120     
  Lines       23150    32781    +9631     
==========================================
+ Hits        16317    20834    +4517     
- Misses       5776    10340    +4564     
- Partials     1057     1607     +550     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericzzzzzzz ericzzzzzzz merged commit eeaf001 into GoogleContainerTools:main Feb 15, 2024
15 checks passed
@noorul
Copy link

noorul commented Feb 15, 2024

Will there be a patch release soon?

@psliwka
Copy link

psliwka commented Feb 27, 2024

Ping, any chance for a new release? We're badly affected by this at $WORK, and I'd prefer very much to simply ask all our devs to upgrade their Skaffold to the newest version from official sources, rather than creating an unofficial distribution channel with an in-house-built Skaffold binary 😞 CC @ericzzzzzzz 🙏

@bhack
Copy link

bhack commented Mar 13, 2024

Gently ping. Any patch release?

zasgar pushed a commit to gimbal-ai/gimbal that referenced this pull request Aug 15, 2024
Summary: @nserrino and I recently ran into some issues where skaffold
wouldn't rebuild a new UI image despite there being changes to the code.
On further investigation, it looks like this was a bug in skaffold.
Upgrade skaffold to ensure that we don't run into this again.
See GoogleContainerTools/skaffold#9313

Relevant Issues: N/A

Type of change: /kind infra

Test Plan: skaffolding controlplane should still work, and update images
as expected.

Signed-off-by: Vihang Mehta <[email protected]>
GitOrigin-RevId: f9a969039e46718e92a0f66185ce8f2d25417daf
zasgar pushed a commit to gimbal-ai/gimbal that referenced this pull request Aug 28, 2024
Summary: @nserrino and I recently ran into some issues where skaffold
wouldn't rebuild a new UI image despite there being changes to the code.
On further investigation, it looks like this was a bug in skaffold.
Upgrade skaffold to ensure that we don't run into this again.
See GoogleContainerTools/skaffold#9313

Relevant Issues: N/A

Type of change: /kind infra

Test Plan: skaffolding controlplane should still work, and update images
as expected.

Signed-off-by: Vihang Mehta <[email protected]>
GitOrigin-RevId: f9a969039e46718e92a0f66185ce8f2d25417daf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants