Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add --load flag for local buildkit #9387

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

Crystalix007
Copy link
Contributor

Description

Adds the --load flag when building images using buildkit, and not pushing to a remote registry.

This is required, to get them loaded into the local docker context.

User facing changes (remove if N/A)

Before:

Running dev complained with:

WARNING: No output specified with docker-container driver. Build result will only remain in the build cache. To push result image into registry use --push or to load image into docker use --load
...
Build [docker.io/...] failed: could not push image "docker.io/...:4002597-dirty": An image does not exist locally with the tag: ...

After:

Tags used in deployment:
 - docker.io/... -> docker.io/crystalix007/...:e1958765598cf4713ec0f5c9d9afa702fccc6098d509d84d272a14b373f422dd

Adds the --load flag when building images using buildkit, and not
pushing to a remote registry.

This is required, to get them loaded into the local docker context.
Adds testing to ensure that the --load flag is applied correctly.
Copy link

google-cla bot commented Apr 13, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ericzzzzzzz ericzzzzzzz added the kokoro:force-run forces a kokoro re-run on a PR label Apr 15, 2024
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Apr 15, 2024
@ericzzzzzzz
Copy link
Contributor

Hi @Crystalix007 Thank you for the contribution! The change looks good, but skaffold integration test infra seems broken at the moment, we'll merge the change after the issue is fixed.

@ericzzzzzzz ericzzzzzzz added the kokoro:force-run forces a kokoro re-run on a PR label Apr 16, 2024
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Apr 16, 2024
@ericzzzzzzz ericzzzzzzz added the kokoro:force-run forces a kokoro re-run on a PR label Apr 17, 2024
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Apr 17, 2024
@ericzzzzzzz ericzzzzzzz merged commit a2f4043 into GoogleContainerTools:main Apr 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants