Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep the original template if template expansion fails #9503

Conversation

ericzzzzzzz
Copy link
Contributor

@ericzzzzzzz ericzzzzzzz commented Aug 20, 2024

  • keep the original template if template expansion fails in skaffold diagnose command because users may not have some values from build available when running this if they have helm deployer/renderer setTemplates configured.
  • We keep the original template unchanged, so users can still use the diagnose result in a later stage. '
  • For example, "repo.tag": {{IMAGE_TAG_BUILD_ARTFIACT_NAME}}, not available in diagnose stage, but it will be provided through --build-artifacts flag in render stage.

@ericzzzzzzz ericzzzzzzz added kokoro:force-run forces a kokoro re-run on a PR kokoro:run runs the kokoro jobs on a PR labels Aug 20, 2024
@kokoro-team kokoro-team removed kokoro:run runs the kokoro jobs on a PR kokoro:force-run forces a kokoro re-run on a PR labels Aug 20, 2024
@ericzzzzzzz ericzzzzzzz merged commit 01bf561 into GoogleContainerTools:main Aug 21, 2024
13 checks passed
ericzzzzzzz added a commit to ericzzzzzzz/skaffold that referenced this pull request Aug 21, 2024
…ntainerTools#9503)

* fix: keep the original template if template expansion fails

* fix: keep the original template if template expansion fails
ericzzzzzzz added a commit that referenced this pull request Aug 21, 2024
…9504)

* fix: keep the original template if template expansion fails
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants