Added property and return types in all places

CHANGELOG.md

@@ -9,6 +9,7 @@ CHANGE LOG
 * Support Laravel 8-10 only
 * `FacadeTrait` methods `getFacadeAccessor`, `getFacadeClass`, `getFacadeRoot` and `getServiceProviderClass` are now `static`
 * `ServiceProviderTrait::getServiceProviderClass` is now `static` and no longer receives app as param 1
+* Added property and return types in all places
 
 
 ## V3.4.1 (25/02/2023)

src/Constraint/ArraySubset.php

@@ -29,12 +29,12 @@ final class ArraySubset extends Constraint
     /**
      * @var iterable
      */
-    private $subset;
+    private iterable $subset;
 
     /**
      * @var bool
      */
-    private $strict;
+    private bool $strict;
 
     /**
      * Create a new array subset constraint instance.

src/FacadeTrait.php

@@ -30,30 +30,30 @@ trait FacadeTrait
      *
      * @return string
      */
-    abstract protected static function getFacadeAccessor();
+    abstract protected static function getFacadeAccessor(): string;
 
     /**
      * Get the facade class.
      *
      * @return string
      */
-    abstract protected static function getFacadeClass();
+    abstract protected static function getFacadeClass(): string;
 
     /**
      * Get the facade root.
      *
      * @return string
      */
-    abstract protected static function getFacadeRoot();
+    abstract protected static function getFacadeRoot(): string;
 
     /**
      * Get the service provider class.
      *
      * @return string
      */
-    abstract protected static function getServiceProviderClass();
+    abstract protected static function getServiceProviderClass(): string;
 
-    public function testIsAFacade()
+    public function testIsAFacade(): void
     {
         $class = static::getFacadeClass();
         $reflection = new ReflectionClass($class);
@@ -64,7 +64,7 @@ public function testIsAFacade()
         static::assertTrue($reflection->isSubclassOf($facade), $msg);
     }
 
-    public function testFacadeAccessor()
+    public function testFacadeAccessor(): void
     {
         $accessor = static::getFacadeAccessor();
         $class = static::getFacadeClass();
@@ -77,7 +77,7 @@ public function testFacadeAccessor()
         static::assertSame($accessor, $method->invoke(null), $msg);
     }
 
-    public function testFacadeRoot()
+    public function testFacadeRoot(): void
     {
         $root = static::getFacadeRoot();
         $class = static::getFacadeClass();
@@ -90,7 +90,7 @@ public function testFacadeRoot()
         static::assertInstanceOf($root, $method->invoke(null), $msg);
     }
 
-    public function testServiceProvider()
+    public function testServiceProvider(): void
     {
         $accessor = static::getFacadeAccessor();
         $provider = static::getServiceProviderClass($this->app);

src/HelperTrait.php

@@ -34,7 +34,7 @@ trait HelperTrait
      *
      * @return void
      */
-    public static function assertInArray($needle, array $haystack, string $msg = '')
+    public static function assertInArray($needle, array $haystack, string $msg = ''): void
     {
         if ($msg === '') {
             $msg = "Expected the array to contain the element '$needle'.";
@@ -52,7 +52,7 @@ public static function assertInArray($needle, array $haystack, string $msg = '')
      *
      * @return void
      */
-    public static function assertMethodExists(string $method, string $class, string $msg = '')
+    public static function assertMethodExists(string $method, string $class, string $msg = ''): void
     {
         if ($msg === '') {
             $msg = "Expected the class '$class' to have method '$method'.";
@@ -72,7 +72,7 @@ public static function assertMethodExists(string $method, string $class, string
      *
      * @return void
      */
-    public static function assertInJson(string $needle, array $haystack, string $msg = '')
+    public static function assertInJson(string $needle, array $haystack, string $msg = ''): void
     {
         if ($msg === '') {
             $msg = "Expected the array to contain the element '$needle'.";

src/LaravelTrait.php

@@ -30,7 +30,7 @@ trait LaravelTrait
      *
      * @return void
      */
-    public function assertIsInjectable(string $name)
+    public function assertIsInjectable(string $name): void
     {
         $injectable = true;
 
@@ -56,7 +56,7 @@ public function assertIsInjectable(string $name)
      *
      * @return object
      */
-    protected function makeInjectableClass(string $name)
+    protected function makeInjectableClass(string $name): object
     {
         do {
             $class = 'testBenchStub'.Str::random();

src/MockeryTrait.php

@@ -29,7 +29,7 @@ trait MockeryTrait
      *
      * @return void
      */
-    public function tearDownMockery()
+    public function tearDownMockery(): void
     {
         if (class_exists(Mockery::class, false)) {
             $container = Mockery::getContainer();

src/ServiceProviderTrait.php

@@ -29,9 +29,9 @@ trait ServiceProviderTrait
      *
      * @return string
      */
-    abstract protected static function getServiceProviderClass();
+    abstract protected static function getServiceProviderClass(): string;
 
-    public function testIsAServiceProvider()
+    public function testIsAServiceProvider(): void
     {
         $class = static::getServiceProviderClass();
 
@@ -44,7 +44,7 @@ public function testIsAServiceProvider()
         static::assertTrue($reflection->isSubclassOf($provider), $msg);
     }
 
-    public function testProvides()
+    public function testProvides(): void
     {
         $class = static::getServiceProviderClass();
         $reflection = new ReflectionClass($class);

tests/AnalysisTest.php

@@ -31,7 +31,7 @@ class AnalysisTest extends TestCase
      *
      * @return string[]
      */
-    protected static function getPaths()
+    protected static function getPaths(): array
     {
         return [
             realpath(__DIR__.'/../src'),
@@ -44,7 +44,7 @@ protected static function getPaths()
      *
      * @return string[]
      */
-    protected static function getIgnored()
+    protected static function getIgnored(): array
     {
         return [
             Application::class,

tests/HelpersTest.php

@@ -23,61 +23,61 @@ class HelpersTest extends TestCase
 {
     use HelperTrait;
 
-    public function testInArray()
+    public function testInArray(): void
     {
         self::assertInArray('foo', ['foo']);
     }
 
-    public function testNotInArray()
+    public function testNotInArray(): void
     {
         self::expectException(ExpectationFailedException::class);
         self::assertInArray('foo', ['bar']);
     }
 
-    public function testMethodDoesExist()
+    public function testMethodDoesExist(): void
     {
         self::assertMethodExists('getBar', FooStub::class);
     }
 
-    public function testMethodDoesNotExist()
+    public function testMethodDoesNotExist(): void
     {
         self::expectException(ExpectationFailedException::class);
         self::assertMethodExists('getFoo', FooStub::class);
     }
 
-    public function testInJson()
+    public function testInJson(): void
     {
         self::assertInJson('{"foo":"bar"}', ['foo' => 'bar']);
         self::assertInJson('{ "foo": "bar", "bar": "baz" }', ['foo' => 'bar']);
         self::assertInJson('{ "foo": "bar", "bar": "baz" }', ['bar' => 'baz']);
     }
 
-    public function testNotInJsonOne()
+    public function testNotInJsonOne(): void
     {
         self::expectException(ExpectationFailedException::class);
         self::assertInJson('{"foo":"baz"}', ['foo' => 'bar']);
     }
 
-    public function testNotInJsonTwo()
+    public function testNotInJsonTwo(): void
     {
         self::expectException(ExpectationFailedException::class);
         self::assertInJson('{ "foo": "bar", "bar": "baz" }', ['foo' => 'baz']);
     }
 
-    public function testBadJsonInNotInJson()
+    public function testBadJsonInNotInJson(): void
     {
         self::expectException(InvalidArgumentException::class);
         self::assertInJson('foobar', ['foo' => 'bar']);
     }
 
-    public function testAssertArraySubsetBadArg1()
+    public function testAssertArraySubsetBadArg1(): void
     {
         $this->expectException(TypeError::class);
 
         self::assertArraySubset(123, []);
     }
 
-    public function testAssertArraySubsetBadArg2()
+    public function testAssertArraySubsetBadArg2(): void
     {
         $this->expectException(TypeError::class);