Merge branch 'aseitz/no-copy-x86-thunks' into 'main'

Do not rename x86 get_pc_thunk.* See merge request rewriting/ddisasm!1178
GrammaTech · Jan 24, 2024 · 60b6702 · 60b6702
2 parents 1c42429 + 6ae95f8
commit 60b6702
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,9 @@
 # 1.8.1 (Unreleased)
 
 * Update LIEF to 0.13.2
+* No longer consider `_x86.get_pc_thunk*` functions as ABI-intrinsic; this
+  means `_copy` is not appended to the original symbol, and a symbol forwarding
+  entry is not created.
 
 # 1.8.0
 

diff --git a/src/datalog/arch/x86_32_symbolization.dl b/src/datalog/arch/x86_32_symbolization.dl
@@ -24,10 +24,6 @@
 x86-32 architecture-specific rules for symbolization
 */
 
-abi_intrinsic(EA,Name):-
-    get_pc_thunk(EA,_),
-    symbol(EA,_,_,_,_,_,_,_,Name).
-
 abi_intrinsic(EA,"_GLOBAL_OFFSET_TABLE_"):-
     (
         symbol(EA,_,_,_,_,_,_,_,"_GLOBAL_OFFSET_TABLE_");