fix(test): fix CLI shutdown #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhult
requested review from
trevorbernard,
robinbb and
Isaac-DeFrain
as code owners
|
@jhult It is true that the PID captured is not the PID of the indexer, but it is a sufficiently good PID to keep because sending it a signal will send a signal to its child (the mina-indexer) as desired. The solution you have here will not work as-is because it backgrounds the 'idxr' command, but that command must not always be backgrounded as it is often used for foreground things. |
jhult
changed the title
robinbb
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #767
The wrong PID was being captured. The PID captured was for a bash process and thus the kill signal wasn't reaching the Indexer itself.