Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix namings so the combiner works again #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Wout-M
Copy link

@Wout-M Wout-M commented Jan 28, 2024

I changed the fetching of the folders and their names from DIM to the naming it currently uses.
I also spaced out the code a bit for easier readability.
I haven't used Java in years (I code in C#) so feel free to comment on the changes.

@Wout-M
Copy link
Author

Wout-M commented Feb 6, 2024

@GreenCauldron08 Hi,

Have you been able to look at this PR?

@GreenCauldron08
Copy link
Owner

My apologies, I didn't notice your pull request until just now. I'll have a look.

@Wout-M
Copy link
Author

Wout-M commented Feb 14, 2024

Hi @GreenCauldron08 , any progress?

@GreenCauldron08
Copy link
Owner

I finally looked into it. I didn't even realize minecraft had changed their dimension naming scheme, and I was confused for a long time cuz I thought you were looking for dimension names that started with "waypoint". Once I figured out that we both had the same idea about how to find the dimension folder's names, it made wayyy more sense. Your idea seems fine.
However, could you possibly submit a version where the formatting hasn't been changed throughout most of the document? That way, people can see where functionality has actually changed instead of the whole document seeming rewritten, and I can more comfortably make changes in the future as well.

@Wout-M
Copy link
Author

Wout-M commented Feb 26, 2024

@GreenCauldron08 Done

@Wout-M
Copy link
Author

Wout-M commented Mar 25, 2024

@GreenCauldron08 Any progress on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants