Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mold client-side calculations #103

Closed
wants to merge 0 commits into from
Closed

Conversation

ICaxapI
Copy link

@ICaxapI ICaxapI commented Jan 31, 2023

Moved the calculation of the removed piece in the mold to the client side instead of the server side (on the server side this calculation is inaccurate due to positioning error)

P.s. Yes, I was very pissed off by another screwed up mold

@GregoriusT
Copy link
Member

Hrrm, this might work, but I definitely need to do some Infrastructure work before I just put a random network handler in there, so I will keep this PR open for now. ^^

@H4ppy-04
Copy link

^ accident mb

@GregoriusT
Copy link
Member

@ICaxapI uhm did you accidentially nuke this PR when you did the other one?

@ICaxapI
Copy link
Author

ICaxapI commented Aug 4, 2024

Oops, indeed, I accidentally broke it.
Anyway, I noticed that it worked great in single player, but didn't work on a separately launched server and a remote client, and I have too little experience with mc network code to fix this. I can reopen the MR and revert these changes back, but they need refinement from experienced eyes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants