-
-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt windows version range >=0.54, <=0.57 #1295
Conversation
Won't the EDIT: Just to be clear: I agree with this change and will happily merge it. :) |
Hmmm yeah libraries shouldn't check in cargo.lock as that makes coordination across contexts like this impossible. I'm not familiar with the issue that resulted in you needing to check it in, but it would be much appreciated if you removed it. Especially if it is no longer necessary 😄 |
Ah I just got educated on https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html and have been told that this does not affect downstream consumers. So I guess I don't care if you keep or remove it / that shouldn't affect us. |
@@ -66,7 +66,7 @@ serde = { version = "^1.0.190", optional = true } | |||
|
|||
[target.'cfg(windows)'.dependencies] | |||
ntapi = "0.4" | |||
windows = { version = "0.56", features = [ | |||
windows = { version = ">=0.54, <=0.57", features = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
windows = { version = ">=0.54, <=0.57", features = [ | |
# Support a range of versions in order to avoid duplication of this crate. Make sure to test all | |
# versions when bumping to a new release, and only increase the minimum when absolutely necessary. | |
windows = { version = ">=0.54, <=0.57", features = [ |
I think a few comments here will help future contributors. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed! That'd be very welcome. :)
Ping @cart (just saw the bevy release, congrats!). |
I made the change in #1326 and added you both as co-authors. Closing this one. |
windows
is a "heavy" crate. Duplicatewindows
versions in a tree can add precious seconds to compile times (or even minutes by some Bevy user reports). On the Bevy side, we are trying to ensure thatwindows
is only compiled once. We also believe it is in the ecosystem's best interest (and in the interest of crate owners that consumewindows
) to align their versioning with the rest of ecosystem. Therefore, I would like to encourage crate owners to adopt the following approach towindows
crate usage:We've picked 0.54 as a baseline because breaking API changes were made to use Rust Results instead of HRESULT.
I have personally tested that sysinfo compiles with 0.54, 0.56 (0.55 does not exist), and 0.57.