Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Material for MKDocs dependencies and update image links #307

Closed
Frichetten opened this issue Dec 20, 2023 · 2 comments
Closed

Update Material for MKDocs dependencies and update image links #307

Frichetten opened this issue Dec 20, 2023 · 2 comments
Labels
bug Something isn't working Working on This I'm currently working on this (note, it may take some time)

Comments

@Frichetten
Copy link
Contributor

There have been some recent warnings in our CI/CD pipeline and it would be wise to deal with them.

  • Check the status for our Material for MKDocs dependencies and fix as needed
  • All images need to be downloaded locally to make sure they don't disappear.
@Frichetten Frichetten added the bug Something isn't working label Dec 20, 2023
@Frichetten
Copy link
Contributor Author

Frichetten commented Jan 6, 2024

Originally this PR was supposed to be fairly easy, but in the time since I created it a new warning has emerged. It looks like MkDocs wan'ts to references images a content and not as a website, so ../../thing.png, instead of /images/thing.png.

This will take a little bit, however it is in the same vein as pulling all images locally, so I suppose this PR should be more about fixing CI/CD warnings.

  • Update dependencies
  • Pull all images locally
  • Update image references to use the right paths.

@Frichetten Frichetten changed the title Update Material for MKDocs dependencies and pull all images locally Update Material for MKDocs dependencies and update image links Jan 6, 2024
@Frichetten Frichetten added the Working on This I'm currently working on this (note, it may take some time) label Feb 19, 2024
@Frichetten
Copy link
Contributor Author

Frichetten commented Feb 19, 2024

Screenshot from 2024-02-19 15-13-30

  • Need to update the GitHub Action Cache version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Working on This I'm currently working on this (note, it may take some time)
Projects
None yet
Development

No branches or pull requests

1 participant