Skip to content

Commit

Permalink
Go back to old hom.
Browse files Browse the repository at this point in the history
  • Loading branch information
HechtiDerLachs committed Feb 4, 2024
1 parent 920fb56 commit a6b7c15
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 0 additions & 2 deletions src/Modules/UngradedModules/FreeModuleHom.jl
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,6 @@ function Base.show(io::IO, fmh::FreeModuleHom{T1, T2, RingMapType}) where {T1 <:
end
end

#=
@doc raw"""
hom(F::FreeMod, G::FreeMod)
Expand Down Expand Up @@ -400,7 +399,6 @@ function hom(F::FreeMod, G::FreeMod)
set_attribute!(GH, :show => Hecke.show_hom, :hom => (F, G), :module_to_hom_map => to_hom_map)
return GH, to_hom_map
end
=#

@doc raw"""
kernel(a::FreeModuleHom)
Expand Down
3 changes: 2 additions & 1 deletion src/Modules/UngradedModules/Hom_and_ext.jl
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ function hom(M::ModuleFP, N::ModuleFP, algorithm::Symbol=:maps)
end

### New and hopefully more maintainable code
#=
function hom(F::FreeMod, G::ModuleFP)
R = base_ring(F)
R === base_ring(G) || error("base rings must be the same")
Expand Down Expand Up @@ -292,7 +293,7 @@ function _hom_graded(F::FreeMod, G::FreeMod)
set_attribute!(H, :show => Hecke.show_hom, :hom => (F, G), :module_to_hom_map => to_hom_map4)
return H, to_hom_map4
end

=#

@doc raw"""
element_to_homomorphism(f::ModuleFPElem)
Expand Down

0 comments on commit a6b7c15

Please sign in to comment.