Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiling in Arduino #218

Closed
msillano opened this issue May 9, 2020 · 3 comments · Fixed by #280
Closed

Compiling in Arduino #218

msillano opened this issue May 9, 2020 · 3 comments · Fixed by #280
Labels
enhancement New feature or request

Comments

@msillano
Copy link

msillano commented May 9, 2020

No description provided.

@msillano
Copy link
Author

msillano commented May 9, 2020

Compiling in Arduino ID (1.8.12) with esp8266\2.7.1 (d1_mini) I get the messages:

D:\User\Documents\progetti2020\arduino\libraries\AutoConnect\src\AutoConnect.cpp: In member function 'bool AutoConnect::begin(const char*, const char*, long unsigned int)':

D:\User\Documents\progetti2020\arduino\libraries\AutoConnect\src\AutoConnect.cpp:112:46: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]

       AC_DBG("Current:%.32s\n", current.ssid);

                                              ^

In file included from D:\User\Documents\progetti2020\arduino\libraries\AutoConnect\src\AutoConnectAux.cpp:14:0:

D:\User\Documents\progetti2020\arduino\libraries\AutoConnect\src\AutoConnectElementBasisImpl.h: In member function 'bool AutoConnectFileBasis::attach(ACFile_t)':

D:\User\Documents\progetti2020\arduino\libraries\AutoConnect\src\AutoConnectElementBasisImpl.h:114:41: warning: 'SPIFFS' is deprecated (declared at C:\Users\Sillano\AppData\Local\Arduino15\packages\esp8266\hardware\esp8266\2.7.1\cores\esp8266/FS.h:269): SPIFFS has been deprecated. Please consider moving to LittleFS or other filesystems. [-Wdeprecated-declarations]

     handlerFS = new AutoConnectUploadFS(SPIFFS);

                                         ^

In file included from D:\User\Documents\progetti2020\arduino\libraries\AutoConnect\src\AutoConnectAux.cpp:16:0:

D:\User\Documents\progetti2020\arduino\libraries\AutoConnect\src\AutoConnectElementJsonImpl.h: In member function 'void AutoConnectElementJson::_setMember(const JsonObject&)':

D:\User\Documents\progetti2020\arduino\libraries\AutoConnect\src\AutoConnectElementJsonImpl.h:96:96: warning: suggest braces around empty body in an 'else' statement [-Wempty-body]

       AC_DBG("Warning '%s' loading, unknown posterior '%s'\n", name.c_str(), posterior.c_str());

                                                                                                ^

D:\User\Documents\progetti2020\arduino\libraries\AutoConnect\src\AutoConnectAux.cpp: At global scope:

D:\User\Documents\progetti2020\arduino\libraries\AutoConnect\src\AutoConnectAux.cpp:464:14: warning: unused parameter 'args' [-Wunused-parameter]

 const String AutoConnectAux::_insertStyle(PageArgument& args) {

              ^
D:\User\Documents\progetti2020\arduino\libraries\PageBuilder\src\PageBuilder.cpp: In member function 'bool PageBuilder::_sink(int, WebServerClass&)':

D:\User\Documents\progetti2020\arduino\libraries\PageBuilder\src\PageBuilder.cpp:163:41: warning: suggest braces around empty body in an 'else' statement [-Wempty-body]

             PB_DBG_DUMB("%d\n", contLen);

                                         ^

D:\User\Documents\progetti2020\arduino\libraries\PageBuilder\src\PageBuilder.cpp: In static member function 'static String PageElement::build(const char*, TokenVT, PageArgument&)':

D:\User\Documents\progetti2020\arduino\libraries\PageBuilder\src\PageBuilder.cpp:373:19: warning: 'SPIFFS' is deprecated (declared at C:\Users\Sillano\AppData\Local\Arduino15\packages\esp8266\hardware\esp8266\2.7.1\cores\esp8266/FS.h:269): SPIFFS has been deprecated. Please consider moving to LittleFS or other filesystems. [-Wdeprecated-declarations]

         File mf = SPIFFS.open(templ.substring(strlen(PAGEELEMENT_FILE)), "r");

                   ^

They are only warning, but...
Best regards
m.s.

@msillano msillano changed the title Compiling in Arduino IDE (1.8.12) I get following messages Compiling in Arduino May 9, 2020
@Hieromon
Copy link
Owner

Hieromon commented May 11, 2020

  1. SPIFFS
    The AutoConnect master is currently in the process of evaluating the ESP8266 arduino core 2.7.0 and does not support yet.
    ESP8266 core recommends migrating from SPIFF to the LittleFS, but AutoConnect does not support LittleFS alone while maintaining backward compatibility. AutoConnect needs to branch the source code pass according to the core version at compile-time, but it does not support yet.
    https://arduino-esp8266.readthedocs.io/en/2.7.1/filesystem.html?highlight=littleFS#spiffs-and-littlefs

    [EDIT]
    The deprecation warning pointed out in this topic appears in core 2.7.0 and above, but SPIFFS still works. (It just changed a few days ago)
    Deprecate SPIFFS, move examples to LittleFS esp8266/Arduino#7263

  2. Empty body warnings
    Well, It should be fixed. I will fix it with v120.

@Hieromon Hieromon added the enhancement New feature or request label May 11, 2020
@Hieromon Hieromon mentioned this issue Dec 2, 2020
@Hieromon
Copy link
Owner

Hieromon commented Dec 2, 2020

Merged #280

@Hieromon Hieromon closed this as completed Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants