Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update esp32.ts #134

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Update esp32.ts #134

merged 2 commits into from
Jun 28, 2023

Conversation

jaykesarkar
Copy link
Contributor

@jaykesarkar jaykesarkar commented Jun 28, 2023 •
edited
Loading

Changed version from 4.4.2 to 4.4.3

@HipsterBrown HipsterBrown linked an issue Jun 28, 2023 that may be closed by this pull request
fix(setup/esp32): update pinned esp-idf version to 4.4.3 #133
Closed
@HipsterBrown
Copy link
Owner

Thanks for creating a PR @JayK1524 👍 Can you combine the changes made in #135 with this PR as well? That will make a more complete fix for #133.

@jaykesarkar
Update esp32.ts
0541c0b 
Changed version from 4.2.2 to 4.3.3
@jaykesarkar
Copy link
Contributor Author

Thanks for creating a PR @JayK1524 👍 Can you combine the changes made in #135 with this PR as well? That will make a more complete fix for #133.

Done.

HipsterBrown
HipsterBrown approved these changes Jun 28, 2023
View reviewed changes
Copy link
Owner

@HipsterBrown HipsterBrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@HipsterBrown HipsterBrown merged commit 83eba8a into HipsterBrown:main Jun 28, 2023
3 checks passed
@HipsterBrown HipsterBrown mentioned this pull request Jun 28, 2023
Closed
@HipsterBrown
Copy link
Owner

This fix has been released with v0.25.13 of the CLI. Thanks for contributing @JayK1524! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HipsterBrown HipsterBrown HipsterBrown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(setup/esp32): update pinned esp-idf version to 4.4.3
2 participants
@jaykesarkar @HipsterBrown