feat(setup): use versioned release artifacts in Windows "xs-dev setup" #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FWIW – in theory it should no longer be necessary to have the debug binaries. There were some unintentional dependencies on the debug binaries but those have been cleaned up. |
HipsterBrown
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update to
xs-dev setupfor Windows mirrors the macOS setup process by:Like on macOS, this approach uses the versioned release tools as both the "release" and "debug" binaries in
build/bin/win/releaseandbuild/bin/win/debug, respectively.When I get a chance, I'll make a new version of #91 built on this change. But no reason to wait on that to get this smaller change in, imho.