Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a config precheck example #243

Merged
merged 6 commits into from
Jul 14, 2024
Merged

Add a config precheck example #243

merged 6 commits into from
Jul 14, 2024

Conversation

saraloo
Copy link
Contributor

@saraloo saraloo commented Jun 26, 2024

Just pulling this example of mine from COVID in to the preprocessing folder as an example. I'm not 100% sure what is different from what @emprzy is working on, but if it becomes redundant feel free to ignore this or overwrite it.

Note this uses an example from COVID19_USA

@saraloo saraloo requested review from jcblemai and emprzy June 26, 2024 19:54
Copy link
Collaborator

@emprzy emprzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is a better version of what I had cobbled together! Good to know I was down the right path. Thanks

@saraloo
Copy link
Contributor Author

saraloo commented Jul 1, 2024

All good! Thanks Emily - feel free to add anything extra you had, or change anything as you see fit.

Copy link
Collaborator

@jcblemai jcblemai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, thank you @saraloo

@saraloo saraloo merged commit 30cf1ec into main Jul 14, 2024
1 check passed
@jcblemai jcblemai deleted the add-precheck branch July 15, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants