Address FutureWarning From pandas.concat In gempyor
#245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidated multiple pd.concat calls into one in compute_all_multioutcomes building hpar df. Addresses pandas FutureWarning in concating an empty df and slightly more performant.
…precation-warnings
jcblemai
requested changes
Jul 11, 2024
There was a problem hiding this comment.
This is all good to me, thanks @TimothyWillard . You are correct that the index is not used so you can remove the call to add this index and it is good to merge. After that, you might want to request review from @emprzy or @saraloo as well so you are sure to have two reviews fast :)
…precation-warnings
`set_index` call maintained prior behavior of creating an index like 0,1,...,N,0,1,...,N. Now the index goes 0,1,...,2N. This index does not get used so it is a harmless breaking change.
jcblemai
approved these changes
Jul 11, 2024
kjsato
reviewed
Jul 11, 2024
kjsato
approved these changes
Jul 11, 2024
|
Thanks y'all! |
TimothyWillard
deleted the
bug/address-gempyor-test-suite-future-weprecation-warnings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to the
compute_all_multioutcomesfunction to build thehpardata frame from a list in one call topandas.concatrather than multiple sequential calls. The benefits are:FutureWarningin Address Warnings Produced BygempyorTest Suite #244 by avoiding concatenation of an empty data frame.pandas.concatcan be expensive. Although since the outputs are relatively small this is a just a nice plus rather than a major benefit.The explicit call to
set_indexis to replicate the old behavior, which is an index of something like 0, 1, ..., N, 0, 1, ..., N which came from concatenating 2 explicit data frames. I can remove that if we don't use this index anywhere, I'm just not familiar enough with the code OTOH to know right now. My guess would be we don't though.Also, not 100% sure I requested the appropriate reviewers, if not please let me know.