rolling_mean_pad
Performance Improvements
#249
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced custom rolling mean implementation using
np.pad
andnp.mean
with implementation based onscipy.ndimage.convolve1d
. This implementation also maintains the window shrinking behavior of the current implementation by manually computing the last row.Addresses GH-248, but there aren't any unit tests for
rolling_mean_pad
right now AFAICT so I would feel much more confident merging this in after GH-247 which adds unit tests for this function (and will probably generate some merge conflicts).