forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround to support older versions of three.js #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mark-114.0.5735.137-r1 to 114-5735.119-1686564984-benchmark-114.0.5735.140-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium-stable Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Stable Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: If3a41d34e662d82eb56eb47298f857899510ce95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619755 Commit-Queue: Chrome Release Autoroll <[email protected]> Bot-Commit: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/5735@{#1305} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
Automatic update for 2023-06-16 UTC Change-Id: I46dbf6b576fb24a7f7add3eb28ab2e51d922c051 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620669 Commit-Queue: PKI Metadata Updates Bot <[email protected]> Bot-Commit: PKI Metadata Updates Bot <[email protected]> Cr-Commit-Position: refs/branch-heads/5735@{#1306} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
Uploaded by https://ci.chromium.org/b/8778177569052715697 Change-Id: I1ba3dcc87aef422a78f298601bac0c83b0b5ad8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620848 Bot-Commit: ChromeOS bot <[email protected]> Commit-Queue: ChromeOS bot <[email protected]> Cr-Commit-Position: refs/branch-heads/5735@{#1307} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
This CL disables OS integration sub managers on M114 as the first step for a kill switch as per http://go/finch-killswitch#merge-policy. This is to prevent crashes on M114. For M115 onwards, the crashes have been fixed, so OS integration release will go on as scheduled. Bug: 1417955 Change-Id: Ib1565b97ca1e7f28d88aefa6f1db88f43f610179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619274 Commit-Queue: Dibyajyoti Pal <[email protected]> Reviewed-by: Daniel Murphy <[email protected]> Cr-Commit-Position: refs/branch-heads/5735@{#1308} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
Note: this CL was automatically generated. If this is suspected to have caused regressions on the affected builders, please feel free to revert. Bug: 1412588 Change-Id: I840933ac7d87668ba9d7551f5de10708e9325c42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621270 Bot-Commit: Rubber Stamper <[email protected]> Commit-Queue: Rubber Stamper <[email protected]> Auto-Submit: Ben Pastene <[email protected]> Cr-Commit-Position: refs/branch-heads/5735@{#1309} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
Change-Id: I8669652374502e7ac5ca883e9526e7a439fc208e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622827 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5735@{#1310} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
This CL updates the ash version ['116.0.5836.0', '115.0.5790.33'] for Lacros version skew testing. This cl only affect linux-lacros config builders like linux-lacros-tester-rel, linux-lacros-rel. This cl will certainly NOT affect Lacros on-device builders (lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab, etc) or any other platforms. If this CL caused regressions, please revert and stop the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller Also please file a bug to OS>LaCrOS>Partner, and CC [email protected]. [email protected] Bug: None Change-Id: I1f655f29e35a0afa59972af27e1e7e193b14fa1c Requires-Testing: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621930 Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/5735@{#1311} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
…-r1-merged This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file go/crostc-bug. Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-stable Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Stable Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: I1dc690113eeaaee741e60e9033fb2a40404c252d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623791 Bot-Commit: Chrome Release Autoroll <[email protected]> Commit-Queue: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/5735@{#1312} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
…114.0.5735.140-r1 to 114-5735.84-1685966868-benchmark-114.0.5735.141-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-arm-chromium-stable Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Stable Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: Ica8f563376ea5b482a1cd9edd3ee75d03cc92ceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624168 Bot-Commit: Chrome Release Autoroll <[email protected]> Commit-Queue: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/5735@{#1313} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
…223-benchmark-114.0.5735.140-r1 to 114-5735.119-1686568223-benchmark-114.0.5735.141-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-arm-exp-chromium-stable Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Stable Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: I54eeecc4481811e783bdddee99b9b2ea2ed52e8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624350 Bot-Commit: Chrome Release Autoroll <[email protected]> Commit-Queue: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/5735@{#1314} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
…mark-114.0.5735.140-r1 to 114-5735.119-1686564984-benchmark-114.0.5735.141-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium-stable Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Stable Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: I760d7bbdd6c102120dbd3676e65146af16d9f1e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624262 Commit-Queue: Chrome Release Autoroll <[email protected]> Bot-Commit: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/5735@{#1315} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
…k-114.0.5735.140-r1 to 114-5735.119-1686568223-benchmark-114.0.5735.141-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium-stable Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Stable Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: I2f3cdacdba7f2588f3ec0183327cf30b45581a61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624368 Commit-Queue: Chrome Release Autoroll <[email protected]> Bot-Commit: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/5735@{#1316} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
Uploaded by https://ci.chromium.org/b/8778086949070914977 Change-Id: I70ffa3fa3e3eb02f2e5bd6f032555da5d2433a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622099 Bot-Commit: ChromeOS bot <[email protected]> Commit-Queue: ChromeOS bot <[email protected]> Cr-Commit-Position: refs/branch-heads/5735@{#1317} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
Change-Id: I964c0e04b87d625ae4e9c898cf3ba8845d52b119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624807 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5735@{#1318} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
This CL updates the ash version ['116.0.5838.0'] for Lacros version skew testing. This cl only affect linux-lacros config builders like linux-lacros-tester-rel, linux-lacros-rel. This cl will certainly NOT affect Lacros on-device builders (lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab, etc) or any other platforms. If this CL caused regressions, please revert and stop the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller Also please file a bug to OS>LaCrOS>Partner, and CC [email protected]. [email protected] Bug: None Change-Id: I5d7ab87a85e8794437c6d9d0d5cd2f3a82c6834d Requires-Testing: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621553 Commit-Queue: Rubber Stamper <[email protected]> Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/5735@{#1319} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
…114.0.5735.129-r1 to 114-5735.119-1686568223-benchmark-114.0.5735.140-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium-stable Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Stable Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: I4b8c1617b7edd723d6d04c190257ae2c52358305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624401 Bot-Commit: Chrome Release Autoroll <[email protected]> Commit-Queue: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/5735@{#1320} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
…-r1-merged This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file go/crostc-bug. Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-stable Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Stable Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: Ic5af6f6cc44941b761433b362b5c8f7b9676df7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624664 Commit-Queue: Chrome Release Autoroll <[email protected]> Bot-Commit: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/5735@{#1321} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
…114.0.5735.141-r1 to 114-5735.84-1685966868-benchmark-114.0.5735.142-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-arm-chromium-stable Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Stable Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: I0c694739b7122cd332b7e72d3b1efc53bd6f4f61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622164 Bot-Commit: Chrome Release Autoroll <[email protected]> Commit-Queue: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/5735@{#1322} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
…223-benchmark-114.0.5735.141-r1 to 114-5735.119-1686568223-benchmark-114.0.5735.142-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-arm-exp-chromium-stable Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Stable Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: Ib14d35fd14b43573b66916d3afae9da0fa2b8901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624892 Commit-Queue: Chrome Release Autoroll <[email protected]> Bot-Commit: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/5735@{#1323} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
…k-114.0.5735.141-r1 to 114-5735.119-1686568223-benchmark-114.0.5735.142-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium-stable Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Stable Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: I63090c0b42ad41e75d374b9ccc39fa6213681f66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624895 Commit-Queue: Chrome Release Autoroll <[email protected]> Bot-Commit: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/5735@{#1324} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
…mark-114.0.5735.141-r1 to 114-5735.119-1686564984-benchmark-114.0.5735.142-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium-stable Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Stable Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: Ibc125b0aeb16e21a5475893d80d4a62d5361d255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624519 Commit-Queue: Chrome Release Autoroll <[email protected]> Bot-Commit: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/5735@{#1325} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
Automatic update for 2023-06-18 UTC Change-Id: Ib20a3213f2d3e44060b8d62942de326b54227b10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625190 Commit-Queue: PKI Metadata Updates Bot <[email protected]> Bot-Commit: PKI Metadata Updates Bot <[email protected]> Cr-Commit-Position: refs/branch-heads/5735@{#1326} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
Automatic update for 2023-06-18 UTC Change-Id: Ie1e211daab79c35a2eb0373247842ade24257d98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625192 Commit-Queue: PKI Metadata Updates Bot <[email protected]> Bot-Commit: PKI Metadata Updates Bot <[email protected]> Cr-Commit-Position: refs/branch-heads/5735@{#1327} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
Uploaded by https://ci.chromium.org/b/8777996256899013505 Change-Id: Id4bc246f23b731c7c96a4f5d3452e9d7c4d6b26a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624788 Bot-Commit: ChromeOS bot <[email protected]> Commit-Queue: ChromeOS bot <[email protected]> Cr-Commit-Position: refs/branch-heads/5735@{#1328} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
Change-Id: Ic8947842bbcddcd4777afa78029b755749459de5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624850 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5735@{#1329} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
Change-Id: I20d36ab1e0e534f393866a7b2310f0bb64e3b0ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625490 Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Auto-Submit: Ben Mason <[email protected]> Cr-Commit-Position: refs/branch-heads/5735@{#1330} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
This CL updates the ash version ['116.0.5840.0'] for Lacros version skew testing. This cl only affect linux-lacros config builders like linux-lacros-tester-rel, linux-lacros-rel. This cl will certainly NOT affect Lacros on-device builders (lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab, etc) or any other platforms. If this CL caused regressions, please revert and stop the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller Also please file a bug to OS>LaCrOS>Partner, and CC [email protected]. [email protected] Bug: None Change-Id: Id7620268e91b3cf6dda931d150e72a9c64957c7d Requires-Testing: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621933 Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/5735@{#1331} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
…-114.0.5735.140-r1 to 114-5735.119-1686568223-benchmark-114.0.5735.141-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium-stable Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Stable Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: I675d41268a58a6d62a2b0e49b324d1998e221ef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625754 Bot-Commit: Chrome Release Autoroll <[email protected]> Commit-Queue: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/5735@{#1332} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
…-r1-merged This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file go/crostc-bug. Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-stable Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Stable Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: Ic7dfc89cdf6ec83f31fa18ff3742d86aa99902c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4626337 Commit-Queue: Chrome Release Autoroll <[email protected]> Bot-Commit: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/5735@{#1333} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
Automatic update for 2023-06-19 UTC Change-Id: I997c2584e8f820ffc63e5ab5eb72834361200262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622400 Commit-Queue: PKI Metadata Updates Bot <[email protected]> Bot-Commit: PKI Metadata Updates Bot <[email protected]> Cr-Commit-Position: refs/branch-heads/5735@{#1334} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
Swap the order of wvr_manager_ and wvr_graphics_ to ensure that wvr_manager_ is destructed before wvr_graphics_. Otherwise, there's a moment where wvr_manager_ holds an invalid raw_ptr to wvr_graphics_. Unset default WvrGraphicsDelegate values that already 0, 0.
This change introduces several small changes to fix various build and runtime errors that are happening after the M114 update.
In this change we copy the chrome code for user level memory pressure signals initialization (adding the corresponding command line flag). Without this, WebXR experiences crash on Oculus Quest 2 devices.
This adds a new class for wrapping all the procedures that involves Wolvic state sync handling. At this moment, I'm mostly interested in splitting away that from WvrManager. We may want to rename this class and its method names eventually to something more suggestive.
This reorganizes the code to choose the frame transport to be used in Wolvic on its own method GetWebXrFrameTransportOptions.
Update DEPS to use wolvic_experimental branch of wolvic-angle instead of chromium's angle. This fixes the performance drops caused by https://crrev.com/c/4300729.
Map data coming from axis to device::Gamepad axes. The code defines a deadZone under which the thumbstick value is considered 0 as done in other parts of the code. Apart from that we're adding a couple of DCHECKs for the amount of buttons and axis coming from Wolvic. They replace an if condition as it should never really happen.
Add a YoutubeURLLoaderRequestInterceptor class which implements logic of ensuring that all youtube requests have the "app=desktop" parameter present. This allows Wolvic browser to play 360 youtube videos correctly.
Add a queue for checking the exact number of produced and processed frames.
It does also a small adjustment to create Java WVRSurfaceTexture only when the SurfaceTexture is also need to be created.
This breaks down the processing frame state in a new method, DrawFrameSubmitNow. This also makes sure (by DCHECKing) that when OnWebXrFrameAvailable runs, the frame arriving is still in the processing state and guaranteeing the correct order functioning as defined by WebXrPresentationState. Besides, it removes an unused member of the main class (last_frame_index_).
Intercept any files that download manager is trying to download and forward them to be handled on the Wolvic side instead.
The input source management was not correct. There were some bugs in the current implementation and there are also some missing very important features. This PR implements the following: * Use the XrStandardGamepadBuilder to create the Gamepad object. This ensures that is created with the xr-standard mapping required by the WebXR implementation. Also it simplifies a bit the code. * Properly fill in the primary_input_* and primary_squeeze_* data. Those 4 values are defined in the WebXR spec (primary action and primary squeeze action) and are used to properly trigger the select* and squeeze* events. This requires storing the previous state of the controllers. * Fix touchpad and thumbstick support. There was no touchpad support at all. Also axes values were not properly filled in. Last but not least, thumbstick's click/touch/value were not filled in. Note: the index for where the data for a particular button is located follows the xr-standard gamepad mapping that can be found https://www.w3.org/TR/webxr-gamepads-module-1/#xr-standard-gamepad-mapping
Add UL suffix to literals in DCHECKS to avoid build errors caused by signed vs unsigned comparison.
Older versions of three.js (until r125) have the following issue mrdoob/three.js#21126 present which breaks certain WebXR experiences like "moonrider" and "construct chess". This workaround makes sure that any WebGL context is marked as XR compatible when possible which means that applications no longer have to mark it manually and in the correct order. This fix is verified to work on both "moonrider" and "construct chess" and also doesn't break sample WebGL pages that don't use WebXR.
60d7a00
to
c08cdef
Compare
jdapena
approved these changes
Sep 11, 2023
Please do not land this until we have discarded all the alternatives |
I'll convert this to a draft since we agreed it's better to fix this issue in moonrider and construct chess rather than in Wolvic. For now we can manually cherry-pick this change for test builds if needed. |
763c56e
to
5343e53
Compare
ebcd9cb
to
c128463
Compare
fe68180
to
6969308
Compare
I'll close this as it is no longer needed after the M124 update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older versions of three.js (until r125) have the following issue mrdoob/three.js#21126 present which breaks certain WebXR experiences like "moonrider" and "construct chess".
This workaround makes sure that any WebGL context is marked as XR compatible when possible which means that applications no longer have to mark it manually and in the correct order. This fix is verified to work on both "moonrider" and "construct chess" and also doesn't break sample WebGL pages that don't use WebXR.