-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/update dependencies chain v1 13 #224
base: dev
Are you sure you want to change the base?
Conversation
…ll go.mod dependencies to sync with injective-core dependencies
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
…use from the go.mod file
… that makes the workflow fail
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #224 +/- ##
==========================================
- Coverage 20.97% 15.77% -5.20%
==========================================
Files 18 25 +7
Lines 3614 4722 +1108
==========================================
- Hits 758 745 -13
- Misses 2828 3946 +1118
- Partials 28 31 +3 ☔ View full report in Codecov by Sentry. |
…ll go.mod dependencies to sync with injective-core dependencies
…use from the go.mod file
… that makes the workflow fail
….com/InjectiveLabs/sdk-go into feat/update_dependencies_chain_v1_13
MinNotional cosmossdk_io_math.LegacyDec `protobuf:"bytes,11,opt,name=min_notional,json=minNotional,proto3,customtype=cosmossdk.io/math.LegacyDec" json:"min_notional"` | ||
// current market admin | ||
Admin string `protobuf:"bytes,12,opt,name=admin,proto3" json:"admin,omitempty"` | ||
// level of admin permissions | ||
AdminPermissions uint32 `protobuf:"varint,13,opt,name=admin_permissions,json=adminPermissions,proto3" json:"admin_permissions,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these looks like new fields in the events @proofofze
OrderHash []byte `protobuf:"bytes,5,opt,name=order_hash,json=orderHash,proto3" json:"order_hash,omitempty"` | ||
FeeRecipientAddress []byte `protobuf:"bytes,6,opt,name=fee_recipient_address,json=feeRecipientAddress,proto3" json:"fee_recipient_address,omitempty"` | ||
Cid string `protobuf:"bytes,7,opt,name=cid,proto3" json:"cid,omitempty"` | ||
Pnl cosmossdk_io_math.LegacyDec `protobuf:"bytes,8,opt,name=pnl,proto3,customtype=cosmossdk.io/math.LegacyDec" json:"pnl"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the famous PNL 🥲 @proofofze
c35ed22
to
c644192
Compare
….com/InjectiveLabs/sdk-go into feat/update_dependencies_chain_v1_13
fix: make PrepareFactory public so chilliass can re-use it
…e and injective-indexer (v1.13 chain upgrade candidates)
This PR will remain a draft until the Indexer version for the chain upgrade to v1.13
Solves CHAIN-109