Fixes NumPy interface bug which did not allow for list/ndarray axes
or s
parameters
#69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NumPy multidimensional FFTs accept
tuple
,list
andnp.ndarray
for theaxes
ands
parameters. Upon substituting a code which ran on standardnumpy
for one running onintel-numpy
, I came across a bug whereaxes
ands
struggled to handle anything apart fromtuple
.This came down to a couple of bugs in
mkl_fft
which are fixed in this PR. In addition, I added a test which should catch these bugs in the future.Edit: Commit 75e9ffd is unrelated to the bug. It's just a code improvement.
Reproducible examples
To simplify checking, here is a list of behaviors which work/do not work currently. This PR fixes them.