Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1313 Attach appropriate function to ipc "select-souce" to fix screen sharing #1315

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Fix #1313 Attach appropriate function to ipc "select-souce" to fix screen sharing #1315

merged 1 commit into from
Jun 25, 2024

Conversation

camspiers
Copy link
Contributor

In order to test I ran:

npm run dist:linux:appimage

Then:

./dist/teams-for-linux-1.7.3.AppImage --no-sandbox

And I was able to successfully screen share during a call.

@camspiers camspiers mentioned this pull request Jun 24, 2024
Closed
hugoalonsocapuz
hugoalonsocapuz approved these changes Jun 25, 2024
View reviewed changes
Copy link

@hugoalonsocapuz hugoalonsocapuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@IsmaelMartinez
Copy link
Owner

Thanks a lot! To avoid confusion with the same 1.7.3 been out one with the fix and one without, can you increase the version number in

teams-for-linux/package.json

Line 3 in d9dee34

"version": "1.7.3",
to 1.7.4 and add a release description in https://github.com/IsmaelMartinez/teams-for-linux/blob/develop/com.github.IsmaelMartinez.teams_for_linux.appdata.xml#L17 ? Really appreciated.

@camspiers
Copy link
Contributor Author

@IsmaelMartinez Updated.

@camspiers
Copy link
Contributor Author

Opps, I noticed I need to do package.json too.

@camspiers
Copy link
Contributor Author

Ready now.

@IsmaelMartinez IsmaelMartinez merged commit 9d2c1dd into IsmaelMartinez:develop Jun 25, 2024
3 checks passed
@IsmaelMartinez
Copy link
Owner

Thanks again! building now so it should be released pretty soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugoalonsocapuz hugoalonsocapuz hugoalonsocapuz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@camspiers @IsmaelMartinez @hugoalonsocapuz