Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site is not working as expected on iOS #943

Closed
oriori opened this issue Jan 27, 2019 · 15 comments
Closed

Site is not working as expected on iOS #943

oriori opened this issue Jan 27, 2019 · 15 comments
Assignees
Labels
bug Critical Needs to be fix ASAP
Milestone

Comments

@oriori
Copy link

oriori commented Jan 27, 2019

Bug

What I expect to happen

Site should load with route

What really happened

Site doesn't load at all

What I did that caused the issue - step by step

Share a route with a link
Open link on a mobile device

My environment

  • Operating System and version:
    iPhone and apparently Android devices as well

  • Web Browser and version:
    Safari and Chrome

Thing I think the developers should know, images, links etc.

This link, for example, doesn't load from mobile: https://israelhiking.osm.org.il/share/QxVAZ2xaCE

@HarelM
Copy link
Member

HarelM commented Jan 27, 2019

I have used the above share on my android device and was able to see the route (ניסיון).
@zstadler @valleyofdawn can you test this as well?
I don't have an iPhone to debug this though...
Is there an error message appearing or just the loading screen is not replaced by the site itself?
Better if you share a screenshot or short video.

@oriori
Copy link
Author

oriori commented Jan 27, 2019

The loading screen is not replaced by the site itself.
I was reported the problem by two other Android users who were unable to open a link I sent them.

@HarelM
Copy link
Member

HarelM commented Jan 27, 2019

Is the link you send them is the link above?
The only way to debug what happens is to connect the android device to the PC and open chrome inspect and look at the error message.
I doubt most people would be able to do it so I'll need a way to reproduce it on my device...

@HarelM
Copy link
Member

HarelM commented Jan 27, 2019

@oriori
Please see if the following helps:

  1. navigate to https://israelhiking.osm.org.il/
  2. click refresh
  3. click on the share that doesn't work.

I see some issues with the browser's cache in some cases that might explain this, maybe...

@oriori
Copy link
Author

oriori commented Jan 27, 2019 via email

@oriori
Copy link
Author

oriori commented Jan 27, 2019 via email

@zstadler zstadler changed the title Can't load shared routes from mobile Can't load site on iOS Jan 27, 2019
@zstadler
Copy link
Member

This is in line with my experiments:

  • iPhone: Safari
  • iPad: Safari, Chrome, and Chrome incognito

@HarelM
Copy link
Member

HarelM commented Jan 27, 2019

@arieltolkachov can you validate this report? any chance you can remote connect to chrome and write here the relevant browser error message?

@HarelM
Copy link
Member

HarelM commented Jan 27, 2019

I'll try to follow these instruction and see if I can manage to debug my iPad using Windows...
https://github.com/RemoteDebug/remotedebug-ios-webkit-adapter

@HarelM
Copy link
Member

HarelM commented Jan 27, 2019

I've created the following site to allow sourcemap etc.
https://israelhiking.osm.org.il/debug/
If anyone can plug an iPhone or iPad to a Mac and use developer tools to see the console it would help a lot.
I was not able to make my MacOS virtual machine recognize my iPad nor able to use the above link to connect to it... :-((

@arieltolkachov
Copy link

OKay I was able to connect my iPhone to a debugger through MacOS. Opening the regular home page (http://israelhiking.osm.org.il) shows no errors, it is just stuck on line (see screenshot attached).

screen shot 2019-01-27 at 22 28 32

Trying to open http://israelhiking.osm.org.il/debug crashes my MacOS Safari debugger, not sure how you managed to do that (-:

If you want to run a screen sharing session ping me directly and I will give you my direct phone number / Skype ID.

@HarelM
Copy link
Member

HarelM commented Jan 27, 2019

I'm now able to debug my iPad using chrome on windows and safari on the iPad.
I also see that it gets stuck in the initialization without any error, I have no clue why.
I'll create a version with a lot of logs and publish it to see what I get.
If this doesn't help I'll rollback to previous version and setup a debug session with you to see how to solve this.
Thanks for the willingness to help out!

@HarelM
Copy link
Member

HarelM commented Jan 27, 2019

Related issue:
pouchdb-community/worker-pouch#53
A possible workaround would be to disable this on iOS...

@HarelM HarelM changed the title Can't load site on iOS Site is not working as expected on iOS Jan 27, 2019
@HarelM
Copy link
Member

HarelM commented Jan 27, 2019

I have made a commit to a fix for the hand problem but now I see that all the icons for single POIs are missing from the map (not the buttons).
Need further investigation, meanwhile, I have reverted to the previous version.

@HarelM HarelM self-assigned this Jan 28, 2019
@HarelM HarelM added bug Critical Needs to be fix ASAP labels Jan 28, 2019
@HarelM HarelM added this to the Next Release milestone Jan 28, 2019
@HarelM HarelM closed this as completed in a4dc7b8 Jan 28, 2019
@HarelM
Copy link
Member

HarelM commented Jan 28, 2019

Yet another issue with the profile menu described here:
angular/components#11677
angular/components#13130
angular/components#11366
I'll try the suggested workarounds.

@HarelM HarelM reopened this Jan 28, 2019
@HarelM HarelM closed this as completed in 3709b47 Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Critical Needs to be fix ASAP
Projects
None yet
Development

No branches or pull requests

4 participants