Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on babel-runtime #3

Closed
pwagener opened this issue Sep 8, 2016 · 2 comments
Closed

Dependency on babel-runtime #3

pwagener opened this issue Sep 8, 2016 · 2 comments
Assignees
Labels

Comments

@pwagener
Copy link

pwagener commented Sep 8, 2016

Attempting to use es6-event-emitter without babel-runtime as a direct dependency results in this error:

module.js:327
    throw err;
    ^

Error: Cannot find module 'babel-runtime/helpers/classCallCheck'
    at Function.Module._resolveFilename (module.js:325:15)
    at Function.Module._load (module.js:276:25)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (/Users/pwagener/Devel/callbacks/node_modules/es6-event-emitter/dist/emitter.js:7:24)
    at Module._compile (module.js:409:26)
    at Module._extensions..js (module.js:416:10)
    at Object.require.extensions.(anonymous function) [as .js] (/Users/pwagener/Devel/callbacks/node_modules/babel-register/lib/node.js:154:7)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
   ...

Adding babel-runtime as a direct dependency of my project seems to resolve it.

@JFusco
Copy link
Owner

JFusco commented Sep 11, 2016

Hey @pwagener - thanks for pointing this out. We actually don't even need babel-runtime. I removed it as a dependency from the package.json file in the latest patch. v1.5.2

I tested it by re-compiling and publishing to NPM..Pulling the new package down in to a regular es6 project - it's building and emitting properly with no errors.

Let me know if you still have issues when you remove babel-runtime from your project. I'll keep this issue open until you can confirm for me.

@JFusco JFusco added the bug label Sep 20, 2016
@JFusco JFusco self-assigned this Sep 20, 2016
@JFusco JFusco closed this as completed Oct 1, 2016
Wkasel added a commit to Wkasel/es6-event-emitter that referenced this issue Oct 22, 2019
@Wkasel
Copy link

Wkasel commented Oct 22, 2019

Still an issue, see #8.

Wkasel added a commit to Wkasel/es6-event-emitter that referenced this issue Oct 22, 2019
…bul, upgraded babel, added environment to .babelrc to support runtime (is it necessary even?), added jest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants