Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Krd/bug/gmst #705

Merged
merged 2 commits into from
May 25, 2023
Merged

Krd/bug/gmst #705

merged 2 commits into from
May 25, 2023

Conversation

kdorheim
Copy link
Contributor

Fix bug so that it returns gmst even if no date is provided it returns the correct value. Update model version.

@kdorheim kdorheim requested a review from bpbond May 25, 2023 19:00
@github-actions
Copy link

Differences in Hector outputs

Hello, this is leeyabot! 🤖

The current pull request's outputs do not differ from 3.0.0 (9aebf67).

@codecov-commenter
Copy link

Codecov Report

Merging #705 (9404bc3) into master (941dc8d) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 9404bc3 differs from pull request most recent head e66bb50. Consider uploading reports for the commit e66bb50 to get more accurate results

@@           Coverage Diff           @@
##           master     #705   +/-   ##
=======================================
  Coverage   79.72%   79.72%           
=======================================
  Files          61       61           
  Lines        5978     5978           
=======================================
  Hits         4766     4766           
  Misses       1212     1212           
Impacted Files Coverage Δ
src/temperature_component.cpp 92.32% <0.00%> (ø)

@bpbond bpbond merged commit 8087ca7 into master May 25, 2023
@bpbond bpbond deleted the krd/bug/gmst branch May 25, 2023 19:27
kdorheim added a commit that referenced this pull request Aug 9, 2023
* Update model version constant to 3.1.0

* Return gmst instead of tas; update model version (#705)

* Add video and tutorial links

* Update to reflect BBL's PR feedback.

---------

Co-authored-by: Robert Gieseke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants