Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the package versions consistent #714

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Conversation

kdorheim
Copy link
Contributor

As it was pointed out in the GMD editor's feedback, there are some inconsistent package versioning numbers. I am not quite sure how it happened but with this PR all the version numbers should be consistent and then we can do a release with the correct number/delete the release with the incorrect versioning number? @bpbond what do you think?

@kdorheim kdorheim requested a review from bpbond August 29, 2023 00:53
@github-actions
Copy link

Differences in Hector outputs

Hello, this is leeyabot! 🤖

The current pull request's outputs do not differ from 3.0.0 (9aebf67).

@codecov-commenter
Copy link

Codecov Report

Merging #714 (bffa247) into master (9027f1f) will not change coverage.
The diff coverage is n/a.

❗ Current head bffa247 differs from pull request most recent head bfc7511. Consider uploading reports for the commit bfc7511 to get more accurate results

@@           Coverage Diff           @@
##           master     #714   +/-   ##
=======================================
  Coverage   79.72%   79.72%           
=======================================
  Files          61       61           
  Lines        5978     5978           
=======================================
  Hits         4766     4766           
  Misses       1212     1212           

Copy link
Member

@bpbond bpbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @kdorheim and I like your plan 👍

@bpbond bpbond merged commit 4337eeb into master Aug 29, 2023
10 checks passed
@bpbond bpbond deleted the krd/consistent_version branch August 29, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants