-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update key parameters after v3.2 calibration #729
Conversation
Differences in Hector outputsHello, this is The current pull request's outputs do not differ from 3.1.1 (d931a00). |
It's not always true that increasing Q10 increases temperature across the board, so update tests to reflect this, instead just testing 2050:2100
Differences in Hector outputsHello, this is The current pull request's outputs do not differ from 3.1.1 (d931a00). |
Differences in Hector outputsHello, this is The current pull request's outputs do not differ from 3.1.1 (d931a00). |
This reverts commit b21e1d5.
Reverting b21e1d5 to let leeyabot comment |
Ummm not sure why leeyabot is failing when it succeeded before... @kdorheim ? |
This reverts commit 6f20d7f.
Differences in Hector outputsHello, this is The current pull request's outputs do not differ from 3.1.1 (d931a00). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #729 +/- ##
======================================
Coverage ? 80.15%
======================================
Files ? 61
Lines ? 5992
Branches ? 0
======================================
Hits ? 4803
Misses ? 1189
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Update the INI files to reflect calibrated values reported by @kdorheim in #728 .
This changes the model behavior in mostly good ways: