Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update key parameters after v3.2 calibration #729

Merged
merged 6 commits into from
Feb 15, 2024
Merged

Update key parameters after v3.2 calibration #729

merged 6 commits into from
Feb 15, 2024

Conversation

bpbond
Copy link
Member

@bpbond bpbond commented Feb 14, 2024

Update the INI files to reflect calibrated values reported by @kdorheim in #728 .

This changes the model behavior in mostly good ways:

cal

@bpbond bpbond linked an issue Feb 14, 2024 that may be closed by this pull request
@bpbond bpbond changed the base branch from main to dev February 14, 2024 18:57
@bpbond bpbond requested a review from kdorheim February 14, 2024 18:57
Copy link

Differences in Hector outputs

Hello, this is leeyabot!

The current pull request's outputs do not differ from 3.1.1 (d931a00).

It's not always true that increasing Q10 increases temperature across the board, so update tests to reflect this, instead just testing 2050:2100
Copy link

Differences in Hector outputs

Hello, this is leeyabot!

The current pull request's outputs do not differ from 3.1.1 (d931a00).

Copy link

Differences in Hector outputs

Hello, this is leeyabot!

The current pull request's outputs do not differ from 3.1.1 (d931a00).

@bpbond
Copy link
Member Author

bpbond commented Feb 14, 2024

Reverting b21e1d5 to let leeyabot comment

@bpbond
Copy link
Member Author

bpbond commented Feb 14, 2024

Ummm not sure why leeyabot is failing when it succeeded before... @kdorheim ?

Copy link

Differences in Hector outputs

Hello, this is leeyabot!

The current pull request's outputs do not differ from 3.1.1 (d931a00).

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (dev@738257a). Click here to learn what that means.

❗ Current head 3f3bca3 differs from pull request most recent head 23df7ab. Consider uploading reports for the commit 23df7ab to get more accurate results

Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #729   +/-   ##
======================================
  Coverage       ?   80.15%           
======================================
  Files          ?       61           
  Lines          ?     5992           
  Branches       ?        0           
======================================
  Hits           ?     4803           
  Misses         ?     1189           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kdorheim kdorheim merged commit 113e6ba into dev Feb 15, 2024
10 checks passed
@kdorheim kdorheim deleted the cal branch February 15, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Hector default parameters in the ini files
3 participants