Fix a minor numeric inconsistency in the hector vignette #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beta = 0.36 seems incorrect, isn't it 0.53. beta <- fetchvars(core, NA, BETA()) beta ## scenario year variable value units ## 1 Unnamed Hector core NA beta 0.53 (unitless) (...) The current value is set to 0.36 (note that it is a unitless quantity, hence the (unitless) unit).
|
Good catch. Thanks for the contribution @mgondan ! |
|
The failure of the check seems to be unrelated (?) |
kdorheim
approved these changes
Apr 9, 2024
|
@mgondan thanks for catching that! the failed check is not a related issue will merge shortly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beta = 0.36 seems incorrect, isn't it 0.53?
(...)
The current value is set to 0.36 (note that it is a unitless quantity, hence the (unitless) unit).