-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addressing a handful of open github issues #741
Merged
Merged
Changes from 9 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
c33764d
Github Issue 718. Add papers to Hector manuscript lists
kdorheim 1d25092
github issue 727. rename FCH4 to RF_CH4 to match all other RF output
kdorheim bd2cd0b
Add a new release checklist
kdorheim 1109310
github issue 734, add output streams
kdorheim 11f690b
quite build message
kdorheim 4846f65
github issue 740, add matilda refernces
kdorheim 542eaef
remove outdated text
kdorheim 678d867
github issue 735, add ref temperature period to plot
kdorheim 029163f
spell check
kdorheim 8771c4d
PR feedback
kdorheim 39a7c02
remove outputstreams to the release assets
kdorheim 99705f3
Ignore the outputstreams
kdorheim c04f3c7
Update the the release checklist
kdorheim 808b1f4
Add the V3.2.0 manuscript
kdorheim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
--- | ||
name: Release | ||
about: Checklist! | ||
--- | ||
|
||
Since the dev branch only includes materials that have been peer-reviewed at least once this PR review process should be relatively smooth should. That being said, before merging this branch into main and the new release is created several things must be completed first. | ||
|
||
* Open a PR into main branch, it should be titled with the new release number | ||
* Let Leeyabot generate a report detailing how the Hector output has changed! | ||
* Add text to the PR documenting the major model changes. The PR is going to serve as an important record | ||
* Update the outputstreams via command line & commit them as part of the PR | ||
* Pass automated checks | ||
* Change the version number in the DESCRIPTION file | ||
* Update the NEWS.md, are links additional materials necessary? Does the release need a new naming file? | ||
* Check to make sure the internal package data is up to date (fxntable, inputstable, unitstable) | ||
|
||
After merging PR | ||
|
||
* Create the release via zenodo | ||
* Add the zenodo links to README / NEWS & push directly to main | ||
* Create new dev branch & update the DESCRIPTION version number to support the pkgdown documentation for the developmental branch! | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -64,7 +64,7 @@ libs/ | |
*.suo | ||
|
||
# Output | ||
output/*.csv | ||
output/tracking*.csv | ||
|
||
# R | ||
.Rhistory | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -58,7 +58,8 @@ hector_tas_results$scenario <- ifelse(hector_tas_results$year <= 2016, "historic | |
ggplot(hector_tas_results) + | ||
geom_line(aes(year, value, color = scenario), linewidth = 1) + | ||
theme_bw(base_size = 15) + | ||
labs(color = NULL, x = NULL, y = expression("Temperature Anomaly ("~degree~"C)")) + | ||
theme(axis.title = element_text(size=12))+ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Super picky, but please |
||
labs(color = NULL, x = NULL, y = expression("Temperature Anomaly Relative to 1750 ("~degree~"C)")) + | ||
scale_color_manual(values = SSP_COLORS) | ||
``` | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,10 @@ | ||
This directory is the location where Hector outputs will be written when running Hector via command line, Xcode, ect. Running Hector through the R interface will __not__ produce any csv outputs here. | ||
|
||
Included are example outputs from Hector driven with ssp245. | ||
TODO update outputstreams before new releases. | ||
|
||
``` | ||
sh test_hector.sh src/hector | ||
``` | ||
|
||
|
||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem with this as way to address #734 is that running an unmodified model will produce modified (from git's point of view) files, because of the timestamp at the top of the outputs...which I don't think is the behavior we want. It seems better to create an
example_outputs/
directory, perhaps as a subdirectory ofoutput/
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm that is a good point, do we want to add that or does it make sense to include the output streams as part of the release materials?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either works, but I like your suggestion.