Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/api tests #68

Open
wants to merge 44 commits into
base: master
Choose a base branch
from
Open

Feature/api tests #68

wants to merge 44 commits into from

Conversation

JMLX42
Copy link
Owner

@JMLX42 JMLX42 commented Oct 15, 2016

No description provided.

Use promises for the API tests.
The first step creates the initial config with all that is required for the API to work.
The second "update" step will update the config with the test App settings.
We need to do this because the config.json file is required to run the add-app.js script.
Refactor all tests to use async/await.
We need this to make sure the tests will continue after an error.
When we run the tests, ballots are likely to be mined after we restore the database. So this error will never end if we don't set it as "no retry".
It's the same idea as why we dump/restore database after each test suite: tests are easier to code if we don't have to worry about the current state of the queue/blockchain.
getVote() will now return the same Vote object for the whole test suite.
In order to have the tests working without an Internet connection, we now use https://localhost as a test URL (instead of https://meetup.com).
The best thing to do would be to actually run a dedicated local server with test assets HTML pages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant