build: add ability to build extension for ocis apps-loading #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saw-jan
commented
Feb 29, 2024
saw-jan
commented
Feb 29, 2024
saw-jan
force-pushed
the
fix/compatible-with-apps-loading
branch
2 times, most recently
from
aebe76a
to
c17688f
Compare
saw-jan
force-pushed
the
fix/compatible-with-apps-loading
branch
from
c17688f
to
2c83243
Compare
saw-jan
changed the title
grgprarup
reviewed
Mar 22, 2024
kulmann
reviewed
Mar 22, 2024
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "id": "com.github.jankaritech.web.mdpresentation", | |||
There was a problem hiding this comment.
I was using it in other files but yeah better move it to index.ts. Thanks
There was a problem hiding this comment.
Ah, No. we need it in vite config as well. Could cause trouble to put it in src/index.ts
@kulmann Does ocis process id in manifest file?
If no and if it doesn't harm then we want to keep it there.
There was a problem hiding this comment.
oCIS doesn't process an id prop from the manifest.
This was referenced Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the option to build the extension for apps loading feature supported by ocis.
Now, to build the extension, we have a new
APPS_LOADINGenv variable to switch between the build types.pnpm build(Default) - build for extension serverAPPS_LOADING=true pnpm build- extension can be loaded by oCIS usingWEB_ASSET_APPS_PATHNeeds: owncloud/ocis#8523
Fixes #31, fixes #30, fixes #45