forked from androidx/androidx
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stability inference flags for non-jvm #1006
Open
eymar
wants to merge
18
commits into
release/compiler-integration
Choose a base branch
from
ok/compiler-fix-stability
base: release/compiler-integration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(not original commit. it's squashed with other changes during rebases)
Change-Id: I983a376b3df1de74346568d9eae805aff67a1557
Disable for overridden symbols too. Disable decoys generation for SAM in fun interfaces fun interfaces can contain only 1 SAM, but decoys generation would add another one (so 2 in total), which leads to an error in further kotlin lowerings (SAM transformation). With this commit, fun interface(s) won't be affected by decoys generation and decoys substitution.
Add HiddenFromObjC to property getter and setter if necessary (#579) Use FqName in HideFromObjCDeclarationsSet Also: mark properties of CompositionLocal type as HiddenFromObjC
This commit removes extra `copyWithNewTypeParams` for calls. It led to new type generation for an anonymous object which didn't the type of 'val a'. Note: Run all tests + tried some new cases, and tested with compose:mpp:demo. This change didn't reveal any new issues. But there is chance it can break something we don't know yet.
Failing CI is okay in this branch - this branch contains only compiler plugin related changes. |
shishkin-pavel
approved these changes
Jan 22, 2024
05316ee
to
bccd756
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.