Run iOS UIKit instrumented tests on simulator #1396

ASalavei · 2024-06-08T09:05:10Z

Run iOS UIKit tests on simulator
Implement basic keyboard appearing tests

Improvements needed:

It's impossible to get a screenshot while running tests.
Keyboard should be operated manually when running tests.

Release Notes

Run iOS UIKit instrumented tests on simulator

MatkovIvan

cc @m-sasha as ui-test owner where you're inctroducing new public APIs
cc @igordmn / @eymar for changes in buildSrc

MatkovIvan · 2024-06-11T23:03:32Z

...ose/ui/ui-test/src/uikitMain/kotlin/androidx/compose/ui/test/ComposeUiTest.uikitMain.test.kt

+    val density = Density(density = UIScreen.mainScreen().scale.toFloat())
+    val window = UIWindow(frame = UIScreen.mainScreen().bounds())
+    val screenSize = DpSize(
+        width = UIScreen.mainScreen().bounds().useContents { size.width.dp },
+        height = UIScreen.mainScreen().bounds().useContents { size.height.dp }
+    )


Let's avoid multiple calls of UIScreen.mainScreen() function

MatkovIvan · 2024-06-11T23:07:45Z

...ose/ui/ui-test/src/uikitMain/kotlin/androidx/compose/ui/test/ComposeUiTest.uikitMain.test.kt

+    fun <T> waitToEquals(expected: () -> T, actual: () -> T, deadline: Duration = 1.seconds) {
+        waitForExpectation(deadline) {
+            expected() == actual()
+        }


I don't think that we need to redefine asserts here

Waiting should be based on isIdle check but not on comparing exect/actual from assert

As I mentioned, isIdle does not work correctly when we're not bound with manually operating clocks.
I will be working on the proper implementation in the following MRs.

MatkovIvan · 2024-06-11T23:14:57Z

buildSrc/private/src/main/kotlin/androidx/build/AndroidXComposeMultiplatformExtensionImpl.kt

@@ -262,4 +266,30 @@ open class AndroidXComposeMultiplatformExtensionImpl @Inject constructor(
            iosSimulatorArm64("uikitSimArm64") { configureFreeCompilerArgs() }
        }
    }
+
+    override fun configureTestsRunInIosSimulatorEnvironment(device: String?): Unit =


We need to be ready to combine AndroidXCompose copy back into AndroidXExtension (used in AOSP and in fork for lifecycle modules).

Please do that changes in AndroidXPlugin instead of AndroidXComposePlugin (or at least in both places).

After discussion with @eymar , we decided to place it here. Let's discuss one more time to have clear understanding.

MatkovIvan · 2024-06-11T23:15:02Z

buildSrc/private/src/main/kotlin/androidx/build/AndroidXComposeMultiplatformExtensionImpl.kt

We need to be ready to combine AndroidXCompose copy back into AndroidXExtension (used in AOSP and in fork for lifecycle modules).

Please do that changes in AndroidXPlugin instead of AndroidXComposePlugin (or at least in both places).

Discussed. Keep it in AndroidXCompose for now.

MatkovIvan · 2024-06-11T23:17:14Z

compose/ui/ui/build.gradle

@@ -146,6 +146,7 @@ if(AndroidXComposePlugin.isMultiplatformEnabled(project)) {
        wasm()

        configureDarwinFlags()
+        configureTestsRunInIosSimulatorEnvironment()


Why should it be explicit call for each module?

It should be explicit call for the module that support tests with booted simulator. For now, only one module needs this environment.

ASalavei · 2024-06-12T08:04:07Z

cc @m-sasha as ui-test owner where you're inctroducing new public APIs

@igordmn , to be clear: we're implementing integration tests for iOS platform, which are not UI tests in their classic definition.

m-sasha · 2024-06-13T09:36:18Z

Without going too deep into the implementation itself, a few concerns:

Should this be in the ui-test module? Perhaps it's better to introduce a new module.
A test API with a "live" app is useful on all target platforms, not just iOS. If we want to release it publicly (even if experimental) perhaps we should design/discuss it upfront, so that we could have a common (or at least cohesive) API across platforms.

ASalavei · 2024-06-14T14:53:49Z

Without going too deep into the implementation itself, a few concerns:

Should this be in the ui-test module? Perhaps it's better to introduce a new module.

A test API with a "live" app is useful on all target platforms, not just iOS. If we want to release it publicly (even if experimental) perhaps we should design/discuss it upfront, so that we could have a common (or at least cohesive) API across platforms.

Test was extracted into another source-set uikitInstrumentedTest (analog to androidInstrumentedTest), to run integration tests having properly configured iOS environment.

compose/ui/ui/build.gradle

compose/ui/ui/src/uikitInstrumentedTest/kotlin/android/compose/ui/test/UIKitInstrumentedTest.kt

igordmn

buildSrc changes LGTM

...ose/ui/ui/src/uikitInstrumentedTest/kotlin/android/compose/ui/keyboard/KeyboardInsetsTest.kt

compose/ui/ui/src/uikitInstrumentedTest/kotlin/android/compose/ui/test/UIKitInstrumentedTest.kt

ASalavei requested review from MatkovIvan and elijah-semyonov June 11, 2024 19:25

ASalavei changed the title ~~Andrei.salavei/run xctests~~ Run iOS UIKit tests on simulator Jun 11, 2024

MatkovIvan reviewed Jun 11, 2024

View reviewed changes

MatkovIvan requested a review from m-sasha June 11, 2024 23:19

ASalavei changed the title ~~Run iOS UIKit tests on simulator~~ [WIP] Run iOS UIKit tests on simulator Jun 12, 2024

ASalavei changed the title ~~[WIP] Run iOS UIKit tests on simulator~~ Run iOS UIKit instrumented tests on simulator Jun 14, 2024

ASalavei marked this pull request as ready for review June 14, 2024 14:39

ASalavei requested a review from MatkovIvan June 14, 2024 14:39

elijah-semyonov approved these changes Jun 25, 2024

View reviewed changes

MatkovIvan requested changes Jun 25, 2024

View reviewed changes

compose/ui/ui/build.gradle Outdated Show resolved Hide resolved

m-sasha reviewed Jun 25, 2024

View reviewed changes

ASalavei requested review from MatkovIvan and m-sasha June 25, 2024 14:24

m-sasha reviewed Jun 25, 2024

View reviewed changes

compose/ui/ui/src/uikitInstrumentedTest/kotlin/android/compose/ui/test/UIKitInstrumentedTest.kt Outdated Show resolved Hide resolved

MatkovIvan approved these changes Jun 25, 2024

View reviewed changes

m-sasha reviewed Jun 25, 2024

View reviewed changes

compose/ui/ui/src/uikitInstrumentedTest/kotlin/android/compose/ui/test/UIKitInstrumentedTest.kt Outdated Show resolved Hide resolved

ASalavei requested a review from m-sasha June 25, 2024 17:57

ASalavei added 9 commits July 2, 2024 17:35

Brake some test

d71e88c

Run parallel tests

63f68e9

Revert tests

f26867a

Run ios tests

ac4276e

Update get device name

ce5d850

Add device check error

ebaced6

Implement keyboard insets test

8c0be88

Move device check to execution phase

9afc2f4

Mut main screen into variable

b7ce7c3

ASalavei added 9 commits July 2, 2024 17:38

Add source set for instrumented tests

32337ac

Implement waitForIdle

b601e8c

Clean up ios instrumented tests setup

ef46951

Increase idle duration

b956c47

Update tests API remove unnessessary dependencies

feee8c5

Update timeout counting loop

c0bf680

Use Monotonic time source

d086d35

Update run test function

fb84abe

Propagate scene invalidations to UIKit instrumented tests

cad7f4c

ASalavei force-pushed the andrei.salavei/run-xctests branch from dfcc821 to cad7f4c Compare July 2, 2024 15:43

ASalavei requested a review from MatkovIvan July 2, 2024 15:45

MatkovIvan approved these changes Jul 2, 2024

View reviewed changes

igordmn approved these changes Jul 2, 2024

View reviewed changes

m-sasha approved these changes Jul 3, 2024

View reviewed changes

Fix MR comments

164fde8

ASalavei merged commit 5a1befe into jb-main Jul 5, 2024
10 checks passed

ASalavei deleted the andrei.salavei/run-xctests branch July 5, 2024 08:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run iOS UIKit instrumented tests on simulator #1396

Run iOS UIKit instrumented tests on simulator #1396

ASalavei commented Jun 8, 2024 •

edited

Loading

MatkovIvan left a comment

MatkovIvan Jun 11, 2024

ASalavei Jun 14, 2024

MatkovIvan Jun 11, 2024

ASalavei Jun 12, 2024 •

edited

Loading

MatkovIvan Jun 11, 2024

ASalavei Jun 12, 2024 •

edited

Loading

MatkovIvan Jun 11, 2024

ASalavei Jun 14, 2024 •

edited

Loading

MatkovIvan Jun 11, 2024

ASalavei Jun 12, 2024 •

edited

Loading

ASalavei commented Jun 12, 2024

m-sasha commented Jun 13, 2024

ASalavei commented Jun 14, 2024

igordmn left a comment

Run iOS UIKit instrumented tests on simulator #1396

Run iOS UIKit instrumented tests on simulator #1396

Conversation

ASalavei commented Jun 8, 2024 • edited Loading

Release Notes

MatkovIvan left a comment

Choose a reason for hiding this comment

MatkovIvan Jun 11, 2024

Choose a reason for hiding this comment

ASalavei Jun 14, 2024

Choose a reason for hiding this comment

MatkovIvan Jun 11, 2024

Choose a reason for hiding this comment

ASalavei Jun 12, 2024 • edited Loading

Choose a reason for hiding this comment

MatkovIvan Jun 11, 2024

Choose a reason for hiding this comment

ASalavei Jun 12, 2024 • edited Loading

Choose a reason for hiding this comment

MatkovIvan Jun 11, 2024

Choose a reason for hiding this comment

ASalavei Jun 14, 2024 • edited Loading

Choose a reason for hiding this comment

MatkovIvan Jun 11, 2024

Choose a reason for hiding this comment

ASalavei Jun 12, 2024 • edited Loading

Choose a reason for hiding this comment

ASalavei commented Jun 12, 2024

m-sasha commented Jun 13, 2024

ASalavei commented Jun 14, 2024

igordmn left a comment

Choose a reason for hiding this comment

ASalavei commented Jun 8, 2024 •

edited

Loading

ASalavei Jun 12, 2024 •

edited

Loading

ASalavei Jun 12, 2024 •

edited

Loading

ASalavei Jun 14, 2024 •

edited

Loading

ASalavei Jun 12, 2024 •

edited

Loading