Fix ModalBottomSheet scrim after merging material3 1.3
#1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
commented
Jul 2, 2024
| because it's logically marked as Destroyed. | ||
| You must create a new CMPViewController and use it instead. (CMPViewControllerMisuse) | ||
| */ | ||
| throw XCTSkip("TODO: Investigate CI fail") |
There was a problem hiding this comment.
FYI it was flaky before, but now CI fails always (3 times in row). Locally it's fine. Agreed with @elijah-semyonov to temporary disable it
igordmn
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CMP-1589
usePlatformDefaultWidthandscrimColor- it's required after migration fromPopup