Add localised string for VoiceOver accessibility support #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alexander Zhirkevich <[email protected]>
igordmn
reviewed
Jul 16, 2024
igordmn
approved these changes
Aug 26, 2024
Co-authored-by: Igor Demin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add localised strings resources (without proofread) for uikit module.
Currently strings will be used for voice announcements when VoiceOver feature is enables on iOS.
Next step: Use
UpdateTranslationsTaskto generate strings accessors in a separate commit.To discuss: consider moving strings as common resources, located in
ui/ui/commonMainmodule.Also, please pay attention on
scripts/convertCrowdinToStringsXml.shthat used to convert directory structure of Crowdin service output into the structure supported by theUpdateTranslationsTask.Release Notes
Add localised string for VoiceOver accessibility support