[maven] IDEA-320329 - non-case sensitive unique artifactId in maven project import #2435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seregamorph
commented
May 14, 2023
plugins/maven/src/main/java/org/jetbrains/idea/maven/importing/MavenModuleNameMapper.java
Show resolved
Hide resolved
zulkar
reviewed
May 16, 2023
plugins/maven/src/test/java/org/jetbrains/idea/maven/importing/MavenModuleNameMapperTest.java
Show resolved
Hide resolved
|
merged manually |
intellij-monorepo-bot
pushed a commit
that referenced
this pull request
Jun 23, 2023
…roject import close #2435 (cherry picked from commit 42ff0b1cdceadb7cb05eebd8fcce2b439a8d2fd1) GitOrigin-RevId: 5f6c4847504a3e847ff1b7f1f7491c55ae4e8b0a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes https://youtrack.jetbrains.com/issue/IDEA-320329
Proposed fix
Do a non-case sensitive comparison when calculating possible repeated module names.
Notes
This implementation does not fix the conflicting module names if according IDEA module already exists, it will only work if the module is new or project is under initial import.
This change can break shared run configurations for multi-module projects with non-unique artifactId names as some modules will now have another name on import from scratch.