-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Arrays page #3292
Update Arrays page #3292
Conversation
af734b0
to
39d4f5e
Compare
39d4f5e
to
085bfa8
Compare
085bfa8
to
cadf1a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some content and structure changes are required here – Arrays are a traditionally tricky subject in Kotlin from a philosophical standpoint, but for more on that, see my detailed comments.
If any of my points (or your changes) directly relate to any of these tickets and contain more reasoning that I somehow overlooked, do let me know, it's a bit hard mapping the individual issues back to all these changes.
4c8bd3f
to
82a33b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already looking better! I've added additional comments on your applied changes, as well as additional points that were uncovered by taking a closer look at the current state of the document.
Also, at least for my PRs: Please don't resolve conversations opened by me. I need to validate that the changes you make reflect my original intention, and that I didn't accidentally miscommunicate or that something fell by the wayside. Once the subject of discussion from a conversation has been addressed, I'll make sure to close them for you!
1ca5d2d
to
34e3065
Compare
This comment was marked as resolved.
This comment was marked as resolved.
1 similar comment
This comment was marked as duplicate.
This comment was marked as duplicate.
34e3065
to
71ed52a
Compare
71ed52a
to
04d03f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now! 🎉🎉🎉
169bdbf
to
15ffb7d
Compare
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Bump! |
15ffb7d
to
4867389
Compare
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
4867389
to
4e6edcd
Compare
9a70e47
to
7bb3945
Compare
7bb3945
to
ca9ff4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge work!
I'm so sorry for so late review, but I think it will help make our docs better.
Besides comments I still have a doubt about the document structure.
I tried to create a new one quickly, but we need to think over it:
-- When to use arrays
-- Create arrays
--- via functions
---- regular
---- empty
---- multidimensional
--- using constructor
-- access and modify elements
--- operator[]
--- getters and setters
--- pass variable (isn't it about accessing array elements?)
-- operations with arrays
--- compare
--- transform
--- concatenate
--- convert array to collection
-- primitive-type arrays
Feel free to contact me if you have any questions or would like to discuss the topic further.
ca9ff4b
to
854db67
Compare
Thanks so much for your review @koshachy!
You can find the latest commit in TC preview. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
I hope it will help our reader to understand Arrays in Kotlin better!
f61bdf1
to
a426340
Compare
This PR updates the Arrays page with additional content.
It will resolve the following YouTrack tickets: