feat: add time API guide #3599
Merged
feat: add time API guide #3599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilya-g
reviewed
Jun 2, 2023
ilya-g
reviewed
Jun 26, 2023
ilya-g
reviewed
Jun 27, 2023
ilya-g
reviewed
Jun 27, 2023
sarahhaggarty
force-pushed
the
1-9-0-docs-update
branch
from
3c0f24e
to
6f67a14
Compare
sarahhaggarty
force-pushed
the
time-api
branch
3 times, most recently
from
157bf96
to
5fdb258
Compare
ilya-g
requested changes
Jul 6, 2023
ilya-g
reviewed
Jul 6, 2023
sarahhaggarty
force-pushed
the
1-9-0-docs-update
branch
from
e7dc251
to
021d99c
Compare
sarahhaggarty
force-pushed
the
time-api
branch
2 times, most recently
from
c1c70b3
to
88fece5
Compare
ilya-g
approved these changes
Jul 17, 2023
danil-pavlov
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
Greate guide! Some minor fixes, feel free to apply or reject
A couple of suggestions:
- I don't think some of the code blocks require sampleStart/ sampleEnd, some of them are already very short. BTW, some sampleStart/ sampleEnd are indented, some are not. Not sure if it affects the appearance, but usually we don't indent these lines
- Have you considered a "What's next" section? the last sentence can be a candidate
sarahhaggarty
force-pushed
the
time-api
branch
2 times, most recently
from
871b6f2
to
4c9b636
Compare
Thanks @danil-pavlov! I fixed the indentation. I've kept the code blocks short because quite a few have the same import lines repeated and I wanted to avoid duplication on the page. I thought about a "What's next" section but I noticed that the other guides don't have one so I've not added one for consistency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a guide for the Stable time API introduced in 1.9.0.