feat: object deinit on the main thread #3633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahhaggarty
force-pushed
the
1-9-0-docs-update
branch
from
3c0f24e
to
6f67a14
Compare
sarahhaggarty
force-pushed
the
1-9-0-docs-update
branch
from
e7dc251
to
021d99c
Compare
danil-pavlov
force-pushed
the
threads-deinit
branch
from
ce6c8cb
to
041da53
Compare
projedi
approved these changes
Jul 10, 2023
koshachy
requested changes
Jul 14, 2023
| ``` | ||
|
|
||
| * If Swift/Objective-C objects are passed to Kotlin on a thread other than main or if the main dispatch queue isn't processed, |
There was a problem hiding this comment.
Maybe this bullet should be a list?
Something like:
Kotlin calls deinit on the S/O objects on a specific GC thread, if:
- S/O objects are passed to Kotlin on a thread other than the main
- Main dispatch queue isn't processed (by the GC?)
If you want to call deinit on .... explicitly, set in your gradle.properties. This property enables deinit calls, even if these objects are passed to Kotlin on the main thread.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.