Rephrase definition of single-expression function #3639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current definition says "When a function returns a single expression", which I don't think is correct: It sounds as if the function returns the expresions inside it. This is an opinionated nitpick, though, so feel free to close this!
sarahhaggarty
requested changes
Jul 19, 2023
|
Yes, that is great! Much better than mine, and clearer than main |
Co-authored-by: Sarah Haggarty <[email protected]>
sarahhaggarty
approved these changes
Jul 19, 2023
|
Thanks for sharing your thoughts with us @vegarsti ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current definition says "When a function returns a single expression", which I don't think is correct: As long as the return type is not
Void, a function always returns a single expression. And it sounds as if the function returns all the expressions inside it.This is an opinionated nitpick, though, so feel free to close this!