Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: js code and sample projects #3692

Merged
merged 2 commits into from
Jul 21, 2023
Merged

update: js code and sample projects #3692

merged 2 commits into from
Jul 21, 2023

Conversation

danil-pavlov
Copy link
Contributor

No description provided.

@danil-pavlov danil-pavlov requested a review from pahill July 19, 2023 13:19
@pahill
Copy link
Collaborator

pahill commented Jul 20, 2023

Something I'm missing is where we add the base-64 npm module as a dependency?

@pahill
Copy link
Collaborator

pahill commented Jul 20, 2023

I'm also not seeing where the module is being used - it's not existing code.
I believe we also needed to make dependency updates?

@danil-pavlov
Copy link
Contributor Author

The thing is that this project wasn't created for this tutorial (and vice versa), they a bit different. I got confused because the sample project uses npm dependency for creating JS tests, but the tutorial doesn't have this part

I've added instructions on how to add an npm dependency to jsMain. The module itself is used to implement JS-specific base64 encoding in separate Base64Npm.kt file

Copy link
Collaborator

@pahill pahill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for making the changes.

@danil-pavlov danil-pavlov merged commit ed29b7c into master Jul 21, 2023
3 checks passed
@danil-pavlov danil-pavlov deleted the mpp-lib-upd branch July 21, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants