chore(alpm): linter fixes

.golangci.yml

@@ -13,7 +13,7 @@ linters:
     - goconst
     - gofmt
     - goimports
-    - golint
+    - revive
     - gosec
     - gosimple
     - govet
@@ -41,8 +41,6 @@ linters:
 linters-settings:
   govet:
     check-shadowing: true
-  golint:
-    min-confidence: 0
   gocyclo:
     min-complexity: 15
   dupl:

Dockerfile

@@ -6,7 +6,7 @@ WORKDIR /app
 
 RUN pacman -Syu --overwrite=* --needed --noconfirm go
 
-RUN curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v1.39.0
+RUN curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v1.41.1
 
 COPY go.mod .
 

callbacks.go

@@ -32,37 +32,37 @@ func DefaultLogCallback(ctx interface{}, lvl LogLevel, s string) {
 }
 
 //export go_alpm_go_log_callback
-func go_alpm_go_log_callback(go_cb unsafe.Pointer, go_ctx C.go_ctx_t, lvl C.alpm_loglevel_t, s *C.char) {
-	cb := *(*logCallbackSig)(go_cb)
-	ctx := logCallbackContextPool[go_ctx]
+func go_alpm_go_log_callback(goCb unsafe.Pointer, goCtx C.go_ctx_t, lvl C.alpm_loglevel_t, s *C.char) {
+	cb := *(*logCallbackSig)(goCb)
+	ctx := logCallbackContextPool[goCtx]
 
 	cb(ctx, LogLevel(lvl), C.GoString(s))
 }
 
 //export go_alpm_go_question_callback
-func go_alpm_go_question_callback(go_cb unsafe.Pointer, go_ctx C.go_ctx_t, question *C.alpm_question_t) {
+func go_alpm_go_question_callback(goCb unsafe.Pointer, goCtx C.go_ctx_t, question *C.alpm_question_t) {
 	q := (*C.alpm_question_any_t)(unsafe.Pointer(question))
 
-	cb := *(*questionCallbackSig)(go_cb)
-	ctx := questionCallbackContextPool[go_ctx]
+	cb := *(*questionCallbackSig)(goCb)
+	ctx := questionCallbackContextPool[goCtx]
 
 	cb(ctx, QuestionAny{q})
 }
 
 func (h *Handle) SetLogCallback(cb logCallbackSig, ctx interface{}) {
-	go_cb := unsafe.Pointer(&cb)
-	go_ctx := C.go_ctx_t(h.ptr)
+	goCb := unsafe.Pointer(&cb)
+	goCtx := C.go_ctx_t(h.ptr)
 
-	logCallbackContextPool[go_ctx] = ctx
+	logCallbackContextPool[goCtx] = ctx
 
-	C.go_alpm_set_log_callback(h.ptr, go_cb, go_ctx)
+	C.go_alpm_set_log_callback(h.ptr, goCb, goCtx)
 }
 
 func (h *Handle) SetQuestionCallback(cb questionCallbackSig, ctx interface{}) {
-	go_cb := unsafe.Pointer(&cb)
-	go_ctx := C.go_ctx_t(h.ptr)
+	goCb := unsafe.Pointer(&cb)
+	goCtx := C.go_ctx_t(h.ptr)
 
-	questionCallbackContextPool[go_ctx] = ctx
+	questionCallbackContextPool[goCtx] = ctx
 
-	C.go_alpm_set_question_callback(h.ptr, go_cb, go_ctx)
+	C.go_alpm_set_question_callback(h.ptr, goCb, goCtx)
 }

db.go

@@ -165,7 +165,7 @@ func (db *DB) Search(targets []string) IPackageList {
 		needles = C.alpm_list_add(needles, unsafe.Pointer(C.CString(str)))
 	}
 
-	ok := C.alpm_db_search(db.ptr, needles, &ret)
+	ok := C.alpm_db_search(db.ptr, needles, &ret) //nolint
 	if ok != 0 {
 		return PackageList{nil, db.handle}
 	}

error.go

@@ -12,8 +12,6 @@ import "C"
 // The Error type represents error codes from libalpm.
 type Error C.alpm_errno_t
 
-var _ error = Error(0)
-
 // The string representation of an error is given by C function
 // alpm_strerror().
 func (er Error) Error() string {

types.go

@@ -90,7 +90,7 @@ func convertFilelist(files *C.alpm_filelist_t) []File {
 		Data: uintptr(unsafe.Pointer(files.files)),
 	}
 
-	cFiles := *(*[]C.alpm_file_t)(unsafe.Pointer(&rawItems)) // nolint
+	cFiles := *(*[]C.alpm_file_t)(unsafe.Pointer(&rawItems)) //nolint
 
 	for i := 0; i < size; i++ {
 		if file, err := convertFile(&cFiles[i]); err == nil {