-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(www): basic dynamic key support #1406
Merged
daniellacosse
merged 37 commits into
master
from
daniellacosse/online_config/static_vs_dynamic
Oct 6, 2022
Merged
feat(www): basic dynamic key support #1406
daniellacosse
merged 37 commits into
master
from
daniellacosse/online_config/static_vs_dynamic
Oct 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniellacosse
commented
Sep 15, 2022
fortuna
requested changes
Sep 19, 2022
fortuna
requested changes
Sep 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some minor changes and tweaks.
Co-authored-by: Vinicius Fortuna <[email protected]>
fortuna
reviewed
Sep 21, 2022
src/www/views/servers_view/server_list_item/server_card/index.ts
Outdated
Show resolved
Hide resolved
daniellacosse
commented
Sep 21, 2022
src/www/views/servers_view/server_list_item/server_card/index.ts
Outdated
Show resolved
Hide resolved
fortuna
approved these changes
Oct 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI piece will be in the next PR. I've left that out due to it requiring translations to merge. With this the address in the UI will just appear blank until a connection is made.