Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(www): basic dynamic key support #1406

Merged
merged 37 commits into from
Oct 6, 2022

Conversation

daniellacosse
Copy link
Contributor

@daniellacosse daniellacosse commented Sep 15, 2022

The UI piece will be in the next PR. I've left that out due to it requiring translations to merge. With this the address in the UI will just appear blank until a connection is made.

Screen Shot 2022-09-25 at 21 38 03

@github-actions github-actions bot added size/S and removed size/XS labels Sep 15, 2022
src/www/app/outline_server_repository/server.ts Outdated Show resolved Hide resolved
src/www/app/outline_server_repository/server.ts Outdated Show resolved Hide resolved
src/www/app/outline_server_repository/server.ts Outdated Show resolved Hide resolved
src/www/app/outline_server_repository/server.ts Outdated Show resolved Hide resolved
src/www/app/outline_server_repository/server.ts Outdated Show resolved Hide resolved
src/www/app/outline_server_repository/index.ts Outdated Show resolved Hide resolved
src/www/app/outline_server_repository/server.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some minor changes and tweaks.

src/www/app/outline_server_repository/index.ts Outdated Show resolved Hide resolved
src/www/app/outline_server_repository/index.ts Outdated Show resolved Hide resolved
src/www/app/outline_server_repository/index.ts Outdated Show resolved Hide resolved
src/www/app/outline_server_repository/server.ts Outdated Show resolved Hide resolved
src/www/app/outline_server_repository/server.ts Outdated Show resolved Hide resolved
src/www/app/outline_server_repository/index.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added size/M and removed size/S labels Sep 20, 2022
src/www/model/server.ts Show resolved Hide resolved
src/www/app/outline_server_repository/index.ts Outdated Show resolved Hide resolved
src/www/app/outline_server_repository/index.ts Outdated Show resolved Hide resolved
src/www/app/outline_server_repository/index.ts Outdated Show resolved Hide resolved
src/www/model/server.ts Outdated Show resolved Hide resolved
@daniellacosse daniellacosse marked this pull request as ready for review September 21, 2022 18:47
@daniellacosse daniellacosse requested a review from a team as a code owner September 21, 2022 18:47
@github-actions github-actions bot added size/L and removed size/M labels Oct 1, 2022
Copy link
Collaborator

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this!

@daniellacosse daniellacosse changed the title feat(www): basic dynamic key support feat(www): [DO NOT MERGE] basic dynamic key support Oct 4, 2022
@daniellacosse daniellacosse changed the title feat(www): [DO NOT MERGE] basic dynamic key support feat(www): [DO NOT MERGE BEFORE RELEASE] basic dynamic key support Oct 4, 2022
@daniellacosse daniellacosse changed the title feat(www): [DO NOT MERGE BEFORE RELEASE] basic dynamic key support feat(www): basic dynamic key support Oct 6, 2022
@daniellacosse daniellacosse merged commit 55cb826 into master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants