This repository has been archived by the owner on Apr 10, 2021. It is now read-only.
Feature/mark tasks as done #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmended to version control
- Adds new Task Layout using constraint layout to show Tasks with checkbox - Adds event listener checkbox to 'update' task status
…e changes in other places
- Updates the migration strategy - Updates the Task Constructor and it's references to reflect the task status boolean flag - Adds temporary approach to delete task on completion
…re/mark_tasks_as_done
- Adds Android JUnit Test Libraries - Adds Basic Unit Test cases for save & update - Removes unnecessary migration strategy
…re/mark_tasks_as_done
- Adds a method to get all the open tasks - Adds a method to get all the open tasks live data - Updates the database query to fetch tasks that has status as '0' - Updates the test cases to verify the database operations BREAKING CHANGE: Introduces a method to get the all the open tasks. i.e., tasks that aren't completed. The app home screen shows the tasks that are open.
- Adds a method to complete the task instead of removing it. BREAKING CHANGE: On clicking on the checkbox, the task status is updated to '1', i.e., marked as completed instead of deleting from database. Swiping from either side will continue to delete the task. This change introduced a bug in the 'Search' screen as the 'Search' screen continue to show all the tasks (open & completed). So when a completed task shown in 'Search Results', unchecking it, may not mark it as 'Not completed'. This is still being worked on.
- Adds a new activity to show the completed tasks - Adds new option to allow opening the completed tasks view - Adds string resources for completed tasks labels & related translations - Fixes the warning in android manifest & adds the new activity definition - Fixes the warning in menu, i.e., uses 'IfRoom' instead of 'always' BREAKING CHANGE: This adds a new activity screen that shows the completed tasks that's launched by clicking on a button in the app bar. It only shows the completed tasks. These tasks can be moved to 'Open/Not completed' stage on clicking the checkbox. It will show up in the main tasks screen as not completed.
- Adds a Task Completion Listener in SearchActivity - Adds a method in SearchTaskModel to update tasks - Updates Task Completion Listener in MainActivity **Note**: The bug was introduced when checkboxes were added & SearchActivity doesn't have a Task Completion Listener. Any action performed in the Search Activity, updated the items in MainActivity since the recycler adapter used the Task Completion Listener in the MainActivity. This has been fixed by adding a separate Task Completion Listener for Search Activity.
- Updates the swipe actions to 'Swipe from Left to Right: Complete the task', 'Swipe from Right to Left: Delete the task' - Fixes the bug when 'undo'ing a completed task by changing the status before saving it
- Adds swipe feature to completed tasks screen - Adds the snackbar with 'undo' actions - Removes unnecessary toast BREAKING CHANGE: The swipe feature is added to completed tasks screen to help the user clean up the tasks. The swipe feauture is in consistent with the main tasks screen with one exception. Swiping from left to right moves the task from 'Completed' to 'Open' status. Swiping from 'Right' to 'Left' deletes the task as similar to Main Tasks Screen.
…e method for clarity
|
Hello, it seems the development has stopped, will you make your branch a new fork so we could get some of those sweet new features? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without a clear answer to my earlier questions, I took some liberty to design the feature on my own. Below are the changes I made and the design considerations.
Swipe Left to Right --> Complete the task
Swipe Right to Left --> Delete the task
With having a screen to see the completed tasks, I felt it would be better if I keep the behavior of swiping from Left to Right action similar to the behavior of the checkbox.
In addition,
I tried to provide enough information in the commit messages. Overall I feel happy about completing the feature, but I may have overstepped my boundaries as a contributor. 😝
Demo
This change is