Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(Dawn): use a clearer fg color for secondary button #22

Merged
merged 1 commit into from
Dec 10, 2023
Merged

Fix(Dawn): use a clearer fg color for secondary button #22

merged 1 commit into from
Dec 10, 2023

Conversation

papey
Copy link
Contributor

@papey papey commented Oct 27, 2023 •
edited
Loading

This PR change the fg text color in the button with a grey background to ensure that the text is readable.

Screenshot 📸 :

Capture d’écran 2023-10-28 à 00 13 21

I am looking for the colors related to the help button but found nothing yet.

Closes #10 #21

@papey papey changed the title Fix(Dawn): use a clearer fg font for secondary button Fix(Dawn): use a clearer fg color for secondary button Oct 27, 2023
Jmorjsm
Jmorjsm approved these changes Dec 10, 2023
View reviewed changes
Copy link
Owner

@Jmorjsm Jmorjsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will include in 0.1.0

@Jmorjsm Jmorjsm merged commit a1f46fe into Jmorjsm:main Dec 10, 2023
@papey papey deleted the fix-10-dawn-secondary-button-color branch December 10, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jmorjsm Jmorjsm Jmorjsm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dawn: secondary button text is dark against a slightly lighter background and hard to read
2 participants
@papey @Jmorjsm